Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18345005: Reporting unterminated comments in CSS. (Closed)

Created:
7 years, 5 months ago by SeRya
Modified:
7 years, 5 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org
Visibility:
Public.

Description

Reporting unterminated comments in CSS. BUG=245264 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153413

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A LayoutTests/inspector/console/console-css-unterminated-comment.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/inspector/console/console-css-unterminated-comment-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
SeRya
7 years, 5 months ago (2013-07-01 14:24:02 UTC) #1
apavlov
LGTM with nit https://chromiumcodereview.appspot.com/18345005/diff/1/LayoutTests/inspector/console/console-css-unterminated-comment.html File LayoutTests/inspector/console/console-css-unterminated-comment.html (right): https://chromiumcodereview.appspot.com/18345005/diff/1/LayoutTests/inspector/console/console-css-unterminated-comment.html#newcode6 LayoutTests/inspector/console/console-css-unterminated-comment.html:6: <style>/*</style> We need to check other ...
7 years, 5 months ago (2013-07-01 14:46:03 UTC) #2
SeRya
https://chromiumcodereview.appspot.com/18345005/diff/1/LayoutTests/inspector/console/console-css-unterminated-comment.html File LayoutTests/inspector/console/console-css-unterminated-comment.html (right): https://chromiumcodereview.appspot.com/18345005/diff/1/LayoutTests/inspector/console/console-css-unterminated-comment.html#newcode6 LayoutTests/inspector/console/console-css-unterminated-comment.html:6: <style>/*</style> On 2013/07/01 14:46:04, apavlov wrote: > We need ...
7 years, 5 months ago (2013-07-02 08:27:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/18345005/6001
7 years, 5 months ago (2013-07-02 08:28:32 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=14636
7 years, 5 months ago (2013-07-02 09:36:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/18345005/6001
7 years, 5 months ago (2013-07-02 09:45:34 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 10:08:15 UTC) #7
Message was sent while issue was closed. 
Change committed as 153413

Powered by Google App Engine
This is Rietveld 408576698