Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4590)

Unified Diff: chrome/test/kasko/hang_watcher_integration_test.py

Issue 1834463002: Identify the hung thread using the Wait Chain Traversal API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BASE_EXPORT Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_watcher/kasko_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/kasko/hang_watcher_integration_test.py
diff --git a/chrome/test/kasko/hang_watcher_integration_test.py b/chrome/test/kasko/hang_watcher_integration_test.py
index b6064fe4b6d68d900a4d377c13acfbdcb2a0749e..24ff9582be518f467c441a2f6760854d083aac12 100755
--- a/chrome/test/kasko/hang_watcher_integration_test.py
+++ b/chrome/test/kasko/hang_watcher_integration_test.py
@@ -16,12 +16,11 @@ most likely lead to constant failures.
Typical usage (assuming in root 'src' directory):
- generate project files with the following build variables:
GYP variables:
- branding=Chrome kasko=1 kasko_hang_reports=1
+ branding=Chrome kasko_hang_reports=1
GN variables:
target_cpu = "x86"
is_debug = false
is_chrome_branded = true
- enable_kasko = true
enable_kasko_hang_reports = true
- build the release Chrome binaries:
ninja -C {build_dir} chrome.exe chromedriver.exe
@@ -46,10 +45,15 @@ _LOGGER = logging.getLogger(os.path.basename(__file__))
def Main():
options = kasko.config.ParseCommandLine()
- kasko.integration_test.RunTest(options,
- 'chrome://delayeduithreadhang',
- 120,
- {'hung-process': 'DumpHungBrowserProcess()'})
+ kasko.integration_test.RunTest(
+ options,
+ 'chrome://delayeduithreadhang',
+ 120,
+ {
+ 'hung-process': 'DumpHungBrowserProcess()',
+ 'hung-process-is-deadlock': 'GetThreadWaitChain()',
+ 'hung-process-wait-chain-00': 'GetThreadWaitChain()',
+ })
_LOGGER.info('Test passed successfully!')
« no previous file with comments | « chrome/chrome_watcher/kasko_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698