Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1029)

Issue 18344016: Add projection touch HUD to keyboard overlay (Closed)

Created:
7 years, 4 months ago by mohsen
Modified:
7 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, mazda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add projection touch HUD to keyboard overlay The shortcut for projection touch HUD is now shown on the keyboard overlay (Ctrl+Alt+/). Also, the shortcut itself was wrongly set to Ctrl+Alt+9 which is now changed to Ctrl+Shift+9. BUG=233567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ash/accelerators/accelerator_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mohsen
Please take a look...
7 years, 4 months ago (2013-07-09 19:43:38 UTC) #1
sky
LGTM
7 years, 4 months ago (2013-07-09 19:49:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/18344016/1
7 years, 4 months ago (2013-07-09 19:50:05 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=173793
7 years, 4 months ago (2013-07-09 21:37:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/18344016/1
7 years, 4 months ago (2013-07-09 22:50:43 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-07-10 00:18:46 UTC) #6
Message was sent while issue was closed.
Change committed as 210683

Powered by Google App Engine
This is Rietveld 408576698