Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 18341026: Don't look up profiles when closing shims. (Closed)

Created:
7 years, 5 months ago by jackhou1
Modified:
7 years, 5 months ago
Reviewers:
tapted
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Don't look up profiles when closing shims. This prevents a crash when shutting down where the profile manager is not available. BUG=257509 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M apps/app_shim/extension_app_shim_handler_mac.cc View 2 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jackhou1
7 years, 5 months ago (2013-07-09 07:26:57 UTC) #1
tapted
+chrome-apps-syd-reviews cool - looks like a nice fix. lgtm (and I guess it's OK not ...
7 years, 5 months ago (2013-07-09 07:38:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/18341026/1
7 years, 5 months ago (2013-07-10 11:37:35 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 14:23:03 UTC) #4
Message was sent while issue was closed.
Change committed as 210836

Powered by Google App Engine
This is Rietveld 408576698