gpu: Fix removal of pending queries.

gpu/command_buffer/client/query_tracker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/client/query_tracker.h"
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
 #include <GLES2/gl2extchromium.h>
 
@@ skipping 181 matching lines @@
 uint32 QueryTracker::Query::GetResult() const {
   GPU_DCHECK(state_ == kComplete || state_ == kUninitialized);
   return result_;
 }
 
 QueryTracker::QueryTracker(MappedMemoryManager* manager)
     : query_sync_manager_(manager) {
 }
 
 QueryTracker::~QueryTracker() {
-  queries_.clear();
+  while (!queries_.empty()) {
+    delete queries_.begin()->second;
+    queries_.erase(queries_.begin());
+  }
+  while (!removed_queries_.empty()) {
+    delete removed_queries_.front();
+    removed_queries_.pop_front();
+  }
 }
 
 QueryTracker::Query* QueryTracker::CreateQuery(GLuint id, GLenum target) {
   GPU_DCHECK_NE(0u, id);
+  FreeCompletedQueries();
   QuerySyncManager::QueryInfo info;
   if (!query_sync_manager_.Alloc(&info)) {
     return NULL;
   }
   Query* query = new Query(id, target, info);
   std::pair<QueryMap::iterator, bool> result =
       queries_.insert(std::make_pair(id, query));
   GPU_DCHECK(result.second);
   return query;
 }
 
 QueryTracker::Query* QueryTracker::GetQuery(
     GLuint client_id) {
   QueryMap::iterator it = queries_.find(client_id);
   return it != queries_.end() ? it->second : NULL;
 }
 
-void QueryTracker::RemoveQuery(GLuint client_id, bool context_lost) {
-  (void)context_lost;  // stop unused warning
+void QueryTracker::RemoveQuery(GLuint client_id) {
   QueryMap::iterator it = queries_.find(client_id);
   if (it != queries_.end()) {
     Query* query = it->second;
-    GPU_DCHECK(context_lost || !query->Pending());
+    // When you delete a query you can't mark its memory as unused until it's
+    // completed.
+    // Note: If you don't do this you won't mess up the service but you will
+    // mess up yourself.
+    removed_queries_.push_back(query);
+    queries_.erase(it);
+    FreeCompletedQueries();
+  }
+}
+
+void QueryTracker::Shrink() {
+  FreeCompletedQueries();
+  query_sync_manager_.Shrink();
+}
+
+void QueryTracker::FreeCompletedQueries() {
+  QueryList::iterator it = removed_queries_.begin();
+  while (it != removed_queries_.end()) {
+    Query* query = *it;
+    if (query->Pending() &&
+        query->info_.sync->process_count != query->submit_count()) {
+      ++it;
+      continue;
+    }
+
     query_sync_manager_.Free(query->info_);
-    queries_.erase(it);
+    it = removed_queries_.erase(it);
     delete query;
   }
 }
 
-void QueryTracker::Shrink() {
-  query_sync_manager_.Shrink();
-}
-
 }  // namespace gles2
 }  // namespace gpu