Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/port/browser/render_widget_host_view_port.h ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index d7490e7283c03f9ade9f2f590d6dd5eed5e36288..b6d2e9babbee5e30e2a590f0d664cd46c23490cd 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -56,12 +56,12 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// just swapped out.
virtual void RenderViewDeleted(RenderViewHost* render_view_host) {}
- // This method is invoked when the current RenderView crashes. The WebContents
- // continues to use the RenderViewHost, e.g. when the user reloads the current
- // page.
+ // This method is invoked when the process for the current RenderView crashes.
+ // The WebContents continues to use the RenderViewHost, e.g. when the user
+ // reloads the current page.
// When the RenderViewHost is deleted, the RenderViewDeleted method will be
// invoked.
- virtual void RenderViewGone(base::TerminationStatus status) {}
+ virtual void RenderProcessGone(base::TerminationStatus status) {}
// This method is invoked after the WebContents decided which RenderViewHost
// to use for the next navigation, but before the navigation starts.
« no previous file with comments | « content/port/browser/render_widget_host_view_port.h ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698