chrome/browser/ui/search/instant_extended_interactive_uitest.cc - Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/instant_extended_interactive_uitest.cc

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/instant_extended_interactive_uitest.cc

diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc

index 344b7e466d3623f1ae41bd7945133472ec8543c8..3aa685165b26ef02a9c25094aa756bd1deeea207 100644

--- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc

+++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc

@@ -457,7 +457,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPForWrongProvider) {

EXPECT_NE(ntp_url, active_tab->GetURL());

}

-IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPRenderViewGone) {

+IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPRenderProcessGone) {

// Setup Instant.

ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));

FocusOmniboxAndWaitForInstantNTPSupport();

@@ -467,7 +467,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPRenderViewGone) {

EXPECT_FALSE(instant()->ntp()->IsLocal());

// NTP not reloaded after being killed.

- instant()->InstantPageRenderViewGone(instant()->ntp()->contents());

+ instant()->InstantPageRenderProcessGone(instant()->ntp()->contents());

EXPECT_EQ(NULL, instant()->ntp());

// Open new tab. Should use local NTP.