Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_view_host_impl.h" 5 #include "content/browser/renderer_host/render_view_host_impl.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 // OnMessageReceived implementation. 911 // OnMessageReceived implementation.
912 bool handled = true; 912 bool handled = true;
913 bool msg_is_ok = true; 913 bool msg_is_ok = true;
914 IPC_BEGIN_MESSAGE_MAP_EX(RenderViewHostImpl, msg, msg_is_ok) 914 IPC_BEGIN_MESSAGE_MAP_EX(RenderViewHostImpl, msg, msg_is_ok)
915 IPC_MESSAGE_HANDLER(ViewHostMsg_ShowView, OnShowView) 915 IPC_MESSAGE_HANDLER(ViewHostMsg_ShowView, OnShowView)
916 IPC_MESSAGE_HANDLER(ViewHostMsg_ShowWidget, OnShowWidget) 916 IPC_MESSAGE_HANDLER(ViewHostMsg_ShowWidget, OnShowWidget)
917 IPC_MESSAGE_HANDLER(ViewHostMsg_ShowFullscreenWidget, 917 IPC_MESSAGE_HANDLER(ViewHostMsg_ShowFullscreenWidget,
918 OnShowFullscreenWidget) 918 OnShowFullscreenWidget)
919 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunModal, OnRunModal) 919 IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunModal, OnRunModal)
920 IPC_MESSAGE_HANDLER(ViewHostMsg_RenderViewReady, OnRenderViewReady) 920 IPC_MESSAGE_HANDLER(ViewHostMsg_RenderViewReady, OnRenderViewReady)
921 IPC_MESSAGE_HANDLER(ViewHostMsg_RenderViewGone, OnRenderViewGone) 921 IPC_MESSAGE_HANDLER(ViewHostMsg_RenderProcessGone, OnRenderProcessGone)
922 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame, 922 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame,
923 OnDidStartProvisionalLoadForFrame) 923 OnDidStartProvisionalLoadForFrame)
924 IPC_MESSAGE_HANDLER(ViewHostMsg_DidRedirectProvisionalLoad, 924 IPC_MESSAGE_HANDLER(ViewHostMsg_DidRedirectProvisionalLoad,
925 OnDidRedirectProvisionalLoad) 925 OnDidRedirectProvisionalLoad)
926 IPC_MESSAGE_HANDLER(ViewHostMsg_DidFailProvisionalLoadWithError, 926 IPC_MESSAGE_HANDLER(ViewHostMsg_DidFailProvisionalLoadWithError,
927 OnDidFailProvisionalLoadWithError) 927 OnDidFailProvisionalLoadWithError)
928 IPC_MESSAGE_HANDLER_GENERIC(ViewHostMsg_FrameNavigate, OnNavigate(msg)) 928 IPC_MESSAGE_HANDLER_GENERIC(ViewHostMsg_FrameNavigate, OnNavigate(msg))
929 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateState, OnUpdateState) 929 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateState, OnUpdateState)
930 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateTitle, OnUpdateTitle) 930 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateTitle, OnUpdateTitle)
931 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateEncoding, OnUpdateEncoding) 931 IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateEncoding, OnUpdateEncoding)
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
1103 // an app-modal fashion. 1103 // an app-modal fashion.
1104 } 1104 }
1105 1105
1106 void RenderViewHostImpl::OnRenderViewReady() { 1106 void RenderViewHostImpl::OnRenderViewReady() {
1107 render_view_termination_status_ = base::TERMINATION_STATUS_STILL_RUNNING; 1107 render_view_termination_status_ = base::TERMINATION_STATUS_STILL_RUNNING;
1108 SendScreenRects(); 1108 SendScreenRects();
1109 WasResized(); 1109 WasResized();
1110 delegate_->RenderViewReady(this); 1110 delegate_->RenderViewReady(this);
1111 } 1111 }
1112 1112
1113 void RenderViewHostImpl::OnRenderViewGone(int status, int exit_code) { 1113 void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) {
1114 // Keep the termination status so we can get at it later when we 1114 // Keep the termination status so we can get at it later when we
1115 // need to know why it died. 1115 // need to know why it died.
1116 render_view_termination_status_ = 1116 render_view_termination_status_ =
1117 static_cast<base::TerminationStatus>(status); 1117 static_cast<base::TerminationStatus>(status);
1118 1118
1119 // Reset state. 1119 // Reset state.
1120 ClearPowerSaveBlockers(); 1120 ClearPowerSaveBlockers();
1121 main_frame_id_ = -1; 1121 main_frame_id_ = -1;
1122 1122
1123 // Our base class RenderWidgetHost needs to reset some stuff. 1123 // Our base class RenderWidgetHost needs to reset some stuff.
(...skipping 945 matching lines...) Expand 10 before | Expand all | Expand 10 after
2069 const std::vector<base::FilePath>& file_paths = state.GetReferencedFiles(); 2069 const std::vector<base::FilePath>& file_paths = state.GetReferencedFiles();
2070 for (std::vector<base::FilePath>::const_iterator file = file_paths.begin(); 2070 for (std::vector<base::FilePath>::const_iterator file = file_paths.begin();
2071 file != file_paths.end(); ++file) { 2071 file != file_paths.end(); ++file) {
2072 if (!policy->CanReadFile(GetProcess()->GetID(), *file)) 2072 if (!policy->CanReadFile(GetProcess()->GetID(), *file))
2073 return false; 2073 return false;
2074 } 2074 }
2075 return true; 2075 return true;
2076 } 2076 }
2077 2077
2078 } // namespace content 2078 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698