Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: content/browser/browser_plugin/test_browser_plugin_guest.cc

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_plugin/test_browser_plugin_guest.h" 5 #include "content/browser/browser_plugin/test_browser_plugin_guest.h"
6 6
7 #include "base/test/test_timeouts.h" 7 #include "base/test/test_timeouts.h"
8 #include "content/browser/renderer_host/render_view_host_impl.h" 8 #include "content/browser/renderer_host/render_view_host_impl.h"
9 #include "content/browser/web_contents/web_contents_impl.h" 9 #include "content/browser/web_contents/web_contents_impl.h"
10 #include "content/common/browser_plugin/browser_plugin_messages.h" 10 #include "content/common/browser_plugin/browser_plugin_messages.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 const gfx::Size& size) { 97 const gfx::Size& size) {
98 if (damage_buffer_call_count_ > 0 && last_damage_buffer_size_ == size) 98 if (damage_buffer_call_count_ > 0 && last_damage_buffer_size_ == size)
99 return; 99 return;
100 100
101 expected_damage_buffer_size_ = size; 101 expected_damage_buffer_size_ = size;
102 waiting_for_damage_buffer_with_size_ = true; 102 waiting_for_damage_buffer_with_size_ = true;
103 damage_buffer_message_loop_runner_ = new MessageLoopRunner(); 103 damage_buffer_message_loop_runner_ = new MessageLoopRunner();
104 damage_buffer_message_loop_runner_->Run(); 104 damage_buffer_message_loop_runner_->Run();
105 } 105 }
106 106
107 void TestBrowserPluginGuest::RenderViewGone(base::TerminationStatus status) { 107 void TestBrowserPluginGuest::RenderProcessGone(base::TerminationStatus status) {
108 exit_observed_ = true; 108 exit_observed_ = true;
109 if (status != base::TERMINATION_STATUS_NORMAL_TERMINATION && 109 if (status != base::TERMINATION_STATUS_NORMAL_TERMINATION &&
110 status != base::TERMINATION_STATUS_STILL_RUNNING) 110 status != base::TERMINATION_STATUS_STILL_RUNNING)
111 LOG(INFO) << "Guest crashed status: " << status; 111 LOG(INFO) << "Guest crashed status: " << status;
112 if (crash_message_loop_runner_.get()) 112 if (crash_message_loop_runner_.get())
113 crash_message_loop_runner_->Quit(); 113 crash_message_loop_runner_->Quit();
114 BrowserPluginGuest::RenderViewGone(status); 114 BrowserPluginGuest::RenderProcessGone(status);
115 } 115 }
116 116
117 void TestBrowserPluginGuest::OnHandleInputEvent( 117 void TestBrowserPluginGuest::OnHandleInputEvent(
118 int instance_id, 118 int instance_id,
119 const gfx::Rect& guest_window_rect, 119 const gfx::Rect& guest_window_rect,
120 const WebKit::WebInputEvent* event) { 120 const WebKit::WebInputEvent* event) {
121 BrowserPluginGuest::OnHandleInputEvent(instance_id, 121 BrowserPluginGuest::OnHandleInputEvent(instance_id,
122 guest_window_rect, 122 guest_window_rect,
123 event); 123 event);
124 input_observed_ = true; 124 input_observed_ = true;
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 279
280 void TestBrowserPluginGuest::DidStopLoading( 280 void TestBrowserPluginGuest::DidStopLoading(
281 RenderViewHost* render_view_host) { 281 RenderViewHost* render_view_host) {
282 BrowserPluginGuest::DidStopLoading(render_view_host); 282 BrowserPluginGuest::DidStopLoading(render_view_host);
283 load_stop_observed_ = true; 283 load_stop_observed_ = true;
284 if (load_stop_message_loop_runner_.get()) 284 if (load_stop_message_loop_runner_.get())
285 load_stop_message_loop_runner_->Quit(); 285 load_stop_message_loop_runner_->Quit();
286 } 286 }
287 287
288 } // namespace content 288 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/browser_plugin/test_browser_plugin_guest.h ('k') | content/browser/devtools/devtools_frontend_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698