Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_plugin/browser_plugin_guest.h" 5 #include "content/browser/browser_plugin/browser_plugin_guest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 875 matching lines...) Expand 10 before | Expand all | Expand 10 after
886 rvh->EnableAutoResize(min_auto_size_, max_auto_size_); 886 rvh->EnableAutoResize(min_auto_size_, max_auto_size_);
887 else 887 else
888 rvh->DisableAutoResize(damage_view_size_); 888 rvh->DisableAutoResize(damage_view_size_);
889 889
890 Send(new ViewMsg_SetName(routing_id(), name_)); 890 Send(new ViewMsg_SetName(routing_id(), name_));
891 891
892 RenderWidgetHostImpl::From(rvh)-> 892 RenderWidgetHostImpl::From(rvh)->
893 set_hung_renderer_delay_ms(guest_hang_timeout_); 893 set_hung_renderer_delay_ms(guest_hang_timeout_);
894 } 894 }
895 895
896 void BrowserPluginGuest::RenderViewGone(base::TerminationStatus status) { 896 void BrowserPluginGuest::RenderProcessGone(base::TerminationStatus status) {
897 int process_id = GetWebContents()->GetRenderProcessHost()->GetID(); 897 int process_id = GetWebContents()->GetRenderProcessHost()->GetID();
898 SendMessageToEmbedder( 898 SendMessageToEmbedder(
899 new BrowserPluginMsg_GuestGone(instance_id(), process_id, status)); 899 new BrowserPluginMsg_GuestGone(instance_id(), process_id, status));
900 switch (status) { 900 switch (status) {
901 case base::TERMINATION_STATUS_PROCESS_WAS_KILLED: 901 case base::TERMINATION_STATUS_PROCESS_WAS_KILLED:
902 RecordAction(UserMetricsAction("BrowserPlugin.Guest.Killed")); 902 RecordAction(UserMetricsAction("BrowserPlugin.Guest.Killed"));
903 break; 903 break;
904 case base::TERMINATION_STATUS_PROCESS_CRASHED: 904 case base::TERMINATION_STATUS_PROCESS_CRASHED:
905 RecordAction(UserMetricsAction("BrowserPlugin.Guest.Crashed")); 905 RecordAction(UserMetricsAction("BrowserPlugin.Guest.Crashed"));
906 break; 906 break;
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 base::Value::CreateStringValue(request_method)); 1520 base::Value::CreateStringValue(request_method));
1521 request_info.Set(browser_plugin::kURL, base::Value::CreateStringValue(url)); 1521 request_info.Set(browser_plugin::kURL, base::Value::CreateStringValue(url));
1522 1522
1523 SendMessageToEmbedder( 1523 SendMessageToEmbedder(
1524 new BrowserPluginMsg_RequestPermission(instance_id(), 1524 new BrowserPluginMsg_RequestPermission(instance_id(),
1525 BrowserPluginPermissionTypeDownload, permission_request_id, 1525 BrowserPluginPermissionTypeDownload, permission_request_id,
1526 request_info)); 1526 request_info));
1527 } 1527 }
1528 1528
1529 } // namespace content 1529 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/browser/browser_plugin/test_browser_plugin_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698