Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/browser/ui/search/instant_controller.h

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/sad_tab_helper.cc ('k') | chrome/browser/ui/search/instant_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_SEARCH_INSTANT_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_SEARCH_INSTANT_CONTROLLER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 UNIT_F(SwitchesToLocalNTPIfNoInstantSupport); 160 UNIT_F(SwitchesToLocalNTPIfNoInstantSupport);
161 UNIT_F(SwitchesToLocalNTPIfNoNTPReady); 161 UNIT_F(SwitchesToLocalNTPIfNoNTPReady);
162 UNIT_F(SwitchesToLocalNTPIfPathBad); 162 UNIT_F(SwitchesToLocalNTPIfPathBad);
163 #undef UNIT_F 163 #undef UNIT_F
164 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ExtendedModeIsOn); 164 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ExtendedModeIsOn);
165 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, MostVisited); 165 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, MostVisited);
166 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, NTPIsPreloaded); 166 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, NTPIsPreloaded);
167 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInNewTab); 167 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInNewTab);
168 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInSameTab); 168 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInSameTab);
169 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPForWrongProvider); 169 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPForWrongProvider);
170 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPRenderViewGone); 170 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPRenderProcessGone);
171 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, 171 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
172 PreloadedNTPDoesntSupportInstant); 172 PreloadedNTPDoesntSupportInstant);
173 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ProcessIsolation); 173 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ProcessIsolation);
174 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, UnrelatedSiteInstance); 174 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, UnrelatedSiteInstance);
175 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, OnDefaultSearchProviderChanged); 175 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, OnDefaultSearchProviderChanged);
176 FRIEND_TEST_ALL_PREFIXES(InstantExtendedNetworkTest, 176 FRIEND_TEST_ALL_PREFIXES(InstantExtendedNetworkTest,
177 NTPReactsToNetworkChanges); 177 NTPReactsToNetworkChanges);
178 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, 178 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
179 AcceptingURLSearchDoesNotNavigate); 179 AcceptingURLSearchDoesNotNavigate);
180 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, AcceptingJSSearchDoesNotRunJS); 180 FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, AcceptingJSSearchDoesNotRunJS);
(...skipping 12 matching lines...) Expand all
193 DispatchMVChangeEventWhileNavigatingBackToNTP); 193 DispatchMVChangeEventWhileNavigatingBackToNTP);
194 194
195 // Overridden from InstantPage::Delegate: 195 // Overridden from InstantPage::Delegate:
196 // TODO(shishir): We assume that the WebContent's current RenderViewHost is 196 // TODO(shishir): We assume that the WebContent's current RenderViewHost is
197 // the RenderViewHost being created which is not always true. Fix this. 197 // the RenderViewHost being created which is not always true. Fix this.
198 virtual void InstantPageRenderViewCreated( 198 virtual void InstantPageRenderViewCreated(
199 const content::WebContents* contents) OVERRIDE; 199 const content::WebContents* contents) OVERRIDE;
200 virtual void InstantSupportDetermined( 200 virtual void InstantSupportDetermined(
201 const content::WebContents* contents, 201 const content::WebContents* contents,
202 bool supports_instant) OVERRIDE; 202 bool supports_instant) OVERRIDE;
203 virtual void InstantPageRenderViewGone( 203 virtual void InstantPageRenderProcessGone(
204 const content::WebContents* contents) OVERRIDE; 204 const content::WebContents* contents) OVERRIDE;
205 virtual void InstantPageAboutToNavigateMainFrame( 205 virtual void InstantPageAboutToNavigateMainFrame(
206 const content::WebContents* contents, 206 const content::WebContents* contents,
207 const GURL& url) OVERRIDE; 207 const GURL& url) OVERRIDE;
208 virtual void FocusOmnibox(const content::WebContents* contents, 208 virtual void FocusOmnibox(const content::WebContents* contents,
209 OmniboxFocusState state) OVERRIDE; 209 OmniboxFocusState state) OVERRIDE;
210 virtual void NavigateToURL( 210 virtual void NavigateToURL(
211 const content::WebContents* contents, 211 const content::WebContents* contents,
212 const GURL& url, 212 const GURL& url,
213 content::PageTransition transition, 213 content::PageTransition transition,
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 // its suggestions with the omnibox. 293 // its suggestions with the omnibox.
294 gfx::Rect omnibox_bounds_; 294 gfx::Rect omnibox_bounds_;
295 295
296 // List of events and their timestamps, useful in debugging Instant behaviour. 296 // List of events and their timestamps, useful in debugging Instant behaviour.
297 mutable std::list<std::pair<int64, std::string> > debug_events_; 297 mutable std::list<std::pair<int64, std::string> > debug_events_;
298 298
299 DISALLOW_COPY_AND_ASSIGN(InstantController); 299 DISALLOW_COPY_AND_ASSIGN(InstantController);
300 }; 300 };
301 301
302 #endif // CHROME_BROWSER_UI_SEARCH_INSTANT_CONTROLLER_H_ 302 #endif // CHROME_BROWSER_UI_SEARCH_INSTANT_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/sad_tab_helper.cc ('k') | chrome/browser/ui/search/instant_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698