Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: chrome/browser/page_cycler/page_cycler_unittest.cc

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/prefs/testing_pref_service.h" 7 #include "base/prefs/testing_pref_service.h"
8 #include "base/strings/string_split.h" 8 #include "base/strings/string_split.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 MOCK_METHOD4(DidFinishLoad, void(int64 frame_id, 58 MOCK_METHOD4(DidFinishLoad, void(int64 frame_id,
59 const GURL& validated_url, 59 const GURL& validated_url,
60 bool is_main_frame, 60 bool is_main_frame,
61 RenderViewHost* render_view_host)); 61 RenderViewHost* render_view_host));
62 MOCK_METHOD6(DidFailProvisionalLoad, void(int64 frame_id, 62 MOCK_METHOD6(DidFailProvisionalLoad, void(int64 frame_id,
63 bool is_main_frame, 63 bool is_main_frame,
64 const GURL& validated_url, 64 const GURL& validated_url,
65 int error_code, 65 int error_code,
66 const string16& error_description, 66 const string16& error_description,
67 RenderViewHost* render_view_host)); 67 RenderViewHost* render_view_host));
68 MOCK_METHOD1(RenderViewGone, void(base::TerminationStatus status)); 68 MOCK_METHOD1(RenderProcessGone, void(base::TerminationStatus status));
69 69
70 void PageCyclerDidFailProvisionalLoad( 70 void PageCyclerDidFailProvisionalLoad(
71 int64 frame_id, 71 int64 frame_id,
72 bool is_main_frame, 72 bool is_main_frame,
73 const GURL& validated_url, 73 const GURL& validated_url,
74 int error_code, 74 int error_code,
75 const string16& error_description, 75 const string16& error_description,
76 RenderViewHost* render_view_host) { 76 RenderViewHost* render_view_host) {
77 PageCycler::DidFailProvisionalLoad(frame_id, is_main_frame, 77 PageCycler::DidFailProvisionalLoad(frame_id, is_main_frame,
78 validated_url, 78 validated_url,
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 .WillRepeatedly(Invoke(page_cycler(), 346 .WillRepeatedly(Invoke(page_cycler(),
347 &MockPageCycler::PageCyclerDidFinishLoad)); 347 &MockPageCycler::PageCyclerDidFinishLoad));
348 348
349 for (int i = 0; i < kNumLoads; ++i) 349 for (int i = 0; i < kNumLoads; ++i)
350 FinishLoad(); 350 FinishLoad();
351 351
352 PumpLoop(); 352 PumpLoop();
353 EXPECT_FALSE(PathExists(errors_file())); 353 EXPECT_FALSE(PathExists(errors_file()));
354 ASSERT_TRUE(PathExists(stats_file())); 354 ASSERT_TRUE(PathExists(stats_file()));
355 } 355 }
OLDNEW
« no previous file with comments | « chrome/browser/notifications/balloon_host.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698