Update ManagedUserService tests to create the service using ManagedUserServiceFactory

Update ManagedUserService tests to create the service using ManagedUserServiceFactory

Using ManagedUserServiceFactory to create the service instead of directly constructing the service allow for correct shutdown (Shutdown method to be called)

To prevent this from happening again we:
1- We DCHECK that Shutdown method is called before destruction of ManagedUserService
2- We make the constructor of ManagedUserService accessible only to ManagedUserServiceFactory

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210677

[Bernhard Bauer, 2013-07-09 12:53:07]

Please add a BUG=.

It would probably be a good idea to add some check that Shutdown is called
before the ManagedUserService is destroyed. We might also want to consider
making the constructor only accessible to ManagedUserServiceFactory to avoid
misuse.

[ibraaaa, 2013-07-09 13:34:21]

On 2013/07/09 12:53:07, Bernhard Bauer wrote:
> Please add a BUG=.
> 
> It would probably be a good idea to add some check that Shutdown is called
> before the ManagedUserService is destroyed. We might also want to consider
> making the constructor only accessible to ManagedUserServiceFactory to avoid
> misuse.

I did both suggestions however I believe that making the constructor accessible
only
to ManagedUserServiceFactory would guarantee proper shutdown.

[Bernhard Bauer, 2013-07-09 14:19:40]

https://codereview.chromium.org/18337013/diff/4001/chrome/browser/managed_mod...
File chrome/browser/managed_mode/managed_user_service.h (right):

https://codereview.chromium.org/18337013/diff/4001/chrome/browser/managed_mod...
chrome/browser/managed_mode/managed_user_service.h:192: explicit
ManagedUserService(Profile* profile);
Can you add a comment that explains how to get the ManagedUserService for a
profile?

https://codereview.chromium.org/18337013/diff/4001/chrome/browser/managed_mod...
chrome/browser/managed_mode/managed_user_service.h:241: // True only when
|Shutdown()| method is called.
Nit: "has been called"

[ibraaaa, 2013-07-09 14:28:34]

https://codereview.chromium.org/18337013/diff/4001/chrome/browser/managed_mod...
File chrome/browser/managed_mode/managed_user_service.h (right):

https://codereview.chromium.org/18337013/diff/4001/chrome/browser/managed_mod...
chrome/browser/managed_mode/managed_user_service.h:192: explicit
ManagedUserService(Profile* profile);
On 2013/07/09 14:19:40, Bernhard Bauer wrote:
> Can you add a comment that explains how to get the ManagedUserService for a
> profile?

Done.

https://codereview.chromium.org/18337013/diff/4001/chrome/browser/managed_mod...
chrome/browser/managed_mode/managed_user_service.h:241: // True only when
|Shutdown()| method is called.
On 2013/07/09 14:19:40, Bernhard Bauer wrote:
> Nit: "has been called"

Done.

[Bernhard Bauer, 2013-07-09 14:32:41]

lgtm

[commit-bot: I haz the power, 2013-07-09 14:43:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ibraaaa@google.com/18337013/9001

[commit-bot: I haz the power, 2013-07-10 00:03:43]

Change committed as 210677