sandbox/linux/services/broker_process_utils.h - Issue 18337010: Avoid std::string copying in GetFileNameInWhitelist.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sandbox/linux/services/broker_process_utils.h

Issue 18337010: Avoid std::string copying in GetFileNameInWhitelist. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« sandbox/linux/services/broker_process.cc ('K') | « sandbox/linux/services/broker_process.cc ('k') | sandbox/linux/services/broker_process_utils.cc » ('j') | sandbox/linux/services/broker_process_utils.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SANDBOX_LINUX_SERVICES_BROKER_PROCESS_UTILS_H_

	6 #define SANDBOX_LINUX_SERVICES_BROKER_PROCESS_UTILS_H_

	7

	8 #include <string>

	9 #include <vector>

	10

	11 namespace sandbox {

	12
	jln (very slow on Chromium) 2013/07/08 22:36:51 Add some documentation about the class and about t Add some documentation about the class and about the fact that it's designed to be async signal safe.
	13 class BrokerProcessUtils {
	jln (very slow on Chromium) 2013/07/08 22:36:51 You absolutely need unit tests as well! You absolutely need unit tests as well! jln (very slow on Chromium) 2013/07/08 22:36:51 Let's name it something less specific, like Sandbo Let's name it something less specific, like SandboxUtils maybe ? Jorge Lucangeli Obes 2013/07/09 03:52:12 Done. Show quoted text On 2013/07/08 22:36:51, Julien Tinnes wrote: > Let's name it something less specific, like SandboxUtils maybe ? Done.
	14 public:

	15 static const char* Find(const char* needle,

	16 const std::vector<std::string>& haystack);
	jln (very slow on Chromium) 2013/07/08 22:36:51 Don't forget to document these functions, even if Don't forget to document these functions, even if it seems pretty straightforward. Especially, mention async signal safety. Jorge Lucangeli Obes 2013/07/09 03:52:12 Done. Show quoted text On 2013/07/08 22:36:51, Julien Tinnes wrote: > Don't forget to document these functions, even if it seems pretty > straightforward. Especially, mention async signal safety. Done.
	17 static int StrCmp(const char* s1, const char* s2);

	18 };
	jln (very slow on Chromium) 2013/07/08 22:36:51 Don't forget DISALLOW_IMPLICIT_CONSTRUCTORS Don't forget DISALLOW_IMPLICIT_CONSTRUCTORS Jorge Lucangeli Obes 2013/07/09 03:52:12 Done. Show quoted text On 2013/07/08 22:36:51, Julien Tinnes wrote: > Don't forget DISALLOW_IMPLICIT_CONSTRUCTORS Done.
	19

	20 } // namespace sandbox

	21

	22 #endif // SANDBOX_LINUX_SERVICES_BROKER_PROCESS_UTILS_H_

OLD	NEW