Clean up base/debug/stack_trace_android.cc.

Clean up base/debug/stack_trace_android.cc.

It's looking like we'll be sticking with <unwind.h> for the forseeable future.

Clean up the code to match Chromium style and remove TODOs relating to switching away from <unwind.h>.

BUG=236855
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210676

[scherkus (not reviewing), 2013-07-08 20:37:27]

digit/dmikurube: PTAL

minor downside to going all Chromium-style is that the code in question will
deviate from the original source, which I believe is Bionic's implementation of
get_backtrace()

Previous CL for reference:
https://codereview.chromium.org/14646012

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
File base/debug/stack_trace_android.cc (right):

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:32: //
http://llvm.org/bugs/show_bug.cgi?id=16564 for details.
FYI: filed bug upstream with llvm to figure out what the deal is

[Dai Mikurube (NOT FULLTIME), 2013-07-09 04:12:43]

Thanks for working on it.  LGTM from the importer.  (I'm however not the OWNER
of this file.)

Deviation from the original was the reason why I kept the style, but I think
it's no problem to clean up.

[scherkus (not reviewing), 2013-07-09 20:11:17]

mark: want to take a look for base/ OWNERS + any other ideas/comments/etc...
relating to cleaning up this code?

[Mark Mentovai, 2013-07-09 20:17:27]

LGTM

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
File base/debug/stack_trace_android.cc (right):

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:31: // Clang's unwind.h doesn't provide
_Unwind_GetIP on ARM, refer to
Tiny nit: comment ought to be indented +2.

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:36: ip &= ~(uintptr_t)0x1;  // Remove thumb
mode bit.
Maybe it’s better to refactor the comment and these three lines (plus a return)
out into their own function guarded by the #ifdef, so that you can write this
function without any #ifdefs.

[scherkus (not reviewing), 2013-07-09 20:31:10]

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
File base/debug/stack_trace_android.cc (right):

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:31: // Clang's unwind.h doesn't provide
_Unwind_GetIP on ARM, refer to
On 2013/07/09 20:17:27, Mark Mentovai wrote:
> Tiny nit: comment ought to be indented +2.

Done.

https://codereview.chromium.org/18337008/diff/1/base/debug/stack_trace_androi...
base/debug/stack_trace_android.cc:36: ip &= ~(uintptr_t)0x1;  // Remove thumb
mode bit.
On 2013/07/09 20:17:27, Mark Mentovai wrote:
> Maybe it’s better to refactor the comment and these three lines (plus a
return)
> out into their own function guarded by the #ifdef, so that you can write this
> function without any #ifdefs.

Ended up defining a local _Unwind_GetIP() guarded by __clang__ ifdef (hopefully
that's what you meant!)

[commit-bot: I haz the power, 2013-07-09 20:31:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/18337008/8001

[Mark Mentovai, 2013-07-09 20:33:22]

LGTM, that’s exactly what I meant.

[commit-bot: I haz the power, 2013-07-10 00:03:16]

Change committed as 210676