Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 18333010: make it possible to disable internal tracing in unofficial builds (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
Reviewers:
dsinclair
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

make it possible to disable internal tracing in unofficial builds Add a tracing_like_official_build gyp setting, which works similarly to the logging_like_official_build setting. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M base/debug/trace_event.h View 1 chunk +11 lines, -2 lines 0 comments Download
M build/common.gypi View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mostyn Bramley-Moore
@dsinclair: does this new gyp setting look reasonable to you?
7 years, 5 months ago (2013-07-08 23:25:53 UTC) #1
dsinclair
lgtm
7 years, 5 months ago (2013-07-09 18:34:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18333010/1
7 years, 5 months ago (2013-07-09 18:54:51 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 21:47:05 UTC) #4
Message was sent while issue was closed.
Change committed as 210650

Powered by Google App Engine
This is Rietveld 408576698