Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 18332019: Allow fractional letter- word-spacing values. (Closed)

Created:
7 years, 5 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 5 months ago
CC:
blink-reviews, jamesr, shans, alancutter (OOO until 2018), eae+blinkwatch, leviw+renderwatch, danakj, dstockwell, dglazkov+blink, Rik, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Stephen Chennney, Steve Block, jeez, pdr.
Visibility:
Public.

Description

Allow fractional letter- and word-spacing values. Previously, fractional values specified or calculated for letter- and word- spacing were truncated to an integer, despite our ability to draw text with floating point precision. Exposing this ability is as simple as changing the data structures involved to store floats. BUG=154289 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153727

Patch Set 1 #

Patch Set 2 : Updating test expectations #

Patch Set 3 : Updating the test expecations file #

Patch Set 4 : Adding one missing file that needs to be rebaselined. #

Patch Set 5 : *actually* add the file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -144 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/svg/text/text-spacing-01-b-expected.txt View 1 chunk +19 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/css1/text_properties/letter_spacing-expected.txt View 4 chunks +30 lines, -30 lines 0 comments Download
M LayoutTests/platform/win/css1/text_properties/word_spacing-expected.txt View 4 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/win/fast/text/basic/013-expected.txt View 1 chunk +28 lines, -28 lines 0 comments Download
M LayoutTests/platform/win/fast/text/text-letter-spacing-expected.txt View 3 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/platform/win/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt View 1 chunk +19 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/svg/batik/text/textLayout-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/text-letter-spacing-expected.txt View 1 chunk +22 lines, -22 lines 0 comments Download
M Source/WebKit/chromium/src/WebFontImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebFontImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/DeprecatedStyleBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/animation/CSSPropertyAnimation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/Font.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/platform/graphics/Font.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
leviw_travelin_and_unemployed
I've verified that we support fractional word and letter spacing when drawing fonts on all ...
7 years, 5 months ago (2013-07-08 16:33:46 UTC) #1
eae
LGTM
7 years, 5 months ago (2013-07-08 16:38:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/18332019/17001
7 years, 5 months ago (2013-07-08 16:38:52 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=3025
7 years, 5 months ago (2013-07-08 16:48:27 UTC) #4
leviw_travelin_and_unemployed
Adding abarth for the Source/WebKit/chromium/src/WebFontImpl.* change.
7 years, 5 months ago (2013-07-08 16:55:44 UTC) #5
jamesr
On windows, at least, Font::drawGlyphs() computes integer advances for each glyph within the run since ...
7 years, 5 months ago (2013-07-08 17:39:21 UTC) #6
leviw_travelin_and_unemployed
On 2013/07/08 17:39:21, jamesr wrote: > On windows, at least, Font::drawGlyphs() computes integer advances for ...
7 years, 5 months ago (2013-07-08 17:49:16 UTC) #7
jamesr
Ah yes, of course. lgtm
7 years, 5 months ago (2013-07-08 20:56:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/18332019/17001
7 years, 5 months ago (2013-07-08 21:04:36 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-08 22:25:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/18332019/17001
7 years, 5 months ago (2013-07-08 22:38:12 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 00:10:19 UTC) #12
Message was sent while issue was closed.
Change committed as 153727

Powered by Google App Engine
This is Rietveld 408576698