media/formats/mp2t/mp2t_stream_parser.cc - Issue 1833053005: Remove MediaTracks::getFirstAudio/VideoConfig

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp2t/mp2t_stream_parser.cc

Issue 1833053005: Remove MediaTracks::getFirstAudio/VideoConfig (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-control

Patch Set: Avoid crashes in tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/mp2t/mp2t_stream_parser.cc

diff --git a/media/formats/mp2t/mp2t_stream_parser.cc b/media/formats/mp2t/mp2t_stream_parser.cc

index 9f43d2d14a746266cd2cece9bc393a484a473e2d..3ff51212a4e60e16f6ce013c954615365bb00da0 100644

--- a/media/formats/mp2t/mp2t_stream_parser.cc

+++ b/media/formats/mp2t/mp2t_stream_parser.cc

@@ -579,7 +579,7 @@ void Mp2tStreamParser::OnEmitAudioBuffer(

// Ignore the incoming buffer if it is not associated with any config.

if (buffer_queue_chain_.empty()) {

- NOTREACHED() << "Cannot provide buffers before configs";

+ LOG(ERROR) << "Cannot provide buffers before configs";

return;

}

« no previous file with comments | « media/formats/common/stream_parser_test_base.cc ('k') | media/formats/mp2t/mp2t_stream_parser_unittest.cc » ('j') | no next file with comments »