Fix ProcMapsTest.ReadProcMaps to work under Valgrind.

Fix ProcMapsTest.ReadProcMaps to work under Valgrind.

Unsurprisingly, verifying details about the stack doesn't work too well if Valgrind creates a different stack for your program.

BUG=256941
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210135

[scherkus (not reviewing), 2013-07-04 01:22:44]

mark: take a look, also added in that comment about found_exe
thestig: FYI

[Mark Mentovai, 2013-07-04 01:28:13]

but LGTM, whatever

https://codereview.chromium.org/18328027/diff/1/base/debug/proc_maps_linux_un...
File base/debug/proc_maps_linux_unittest.cc (right):

https://codereview.chromium.org/18328027/diff/1/base/debug/proc_maps_linux_un...
base/debug/proc_maps_linux_unittest.cc:206: if (regions[i].path == "[stack]") {
So now you’re looking for duplicate stacks based on their saying [stack] and not
based on the addresses containing the target address more than once. Hmm, I
think it’s a better test to look for the addresses (or do both).

[scherkus (not reviewing), 2013-07-04 01:44:39]

https://codereview.chromium.org/18328027/diff/1/base/debug/proc_maps_linux_un...
File base/debug/proc_maps_linux_unittest.cc (right):

https://codereview.chromium.org/18328027/diff/1/base/debug/proc_maps_linux_un...
base/debug/proc_maps_linux_unittest.cc:206: if (regions[i].path == "[stack]") {
On 2013/07/04 01:28:13, Mark Mentovai wrote:
> So now you’re looking for duplicate stacks based on their saying [stack] and
not
> based on the addresses containing the target address more than once. Hmm, I
> think it’s a better test to look for the addresses (or do both).

Ooooo I like both. Done.

[commit-bot: I haz the power, 2013-07-04 01:45:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/18328027/8001

[commit-bot: I haz the power, 2013-07-04 06:06:15]

Change committed as 210135