Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 18325027: Revert "Introduce a handle zapping setting, and enable it by default for release and debug" due to … (Closed)

Created:
7 years, 5 months ago by Toon Verwaest
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Introduce a handle zapping setting, and enable it by default for release and debug" due to performance impact. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -31 lines) Patch
M Makefile View 1 chunk +0 lines, -7 lines 0 comments Download
M build/common.gypi View 3 chunks +0 lines, -8 lines 0 comments Download
M src/api.h View 1 chunk +3 lines, -8 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/global-handles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/handles.h View 1 chunk +1 line, -1 line 0 comments Download
M src/handles.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/handles-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 5 months ago (2013-07-08 13:57:19 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-08 15:18:43 UTC) #2
Toon Verwaest
7 years, 5 months ago (2013-07-08 15:28:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698