Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: build/android/pylib/browsertests/dispatch.py

Issue 18323020: Updates the test runner script exit codes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes Python dispatch issues in test_runner.py Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/base/shard_unittest.py ('k') | build/android/pylib/buildbot_report.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/browsertests/dispatch.py
diff --git a/build/android/pylib/browsertests/dispatch.py b/build/android/pylib/browsertests/dispatch.py
index 8457cf2f618986b8f1bad9770d3273bf9eabf35a..3867dc3a18dfd1c22b89085b59a1fa23d646371d 100644
--- a/build/android/pylib/browsertests/dispatch.py
+++ b/build/android/pylib/browsertests/dispatch.py
@@ -23,7 +23,15 @@ from common import unittest_util
def Dispatch(options):
- """Dispatches all content_browsertests."""
+ """Dispatches all content_browsertests.
+
+ Args:
+ options: optparse.Options object containing command-line options
+ Returns:
+ A tuple of (base_test_result.TestRunResults object, exit code).
+ Raises:
+ Exception: Failed to reset the test server port.
+ """
attached_devices = []
if options.test_device:
@@ -75,20 +83,18 @@ def Dispatch(options):
# TODO(nileshagrawal): remove this abnormally long setup timeout once fewer
# files are pushed to the devices for content_browsertests: crbug.com/138275
setup_timeout = 20 * 60 # 20 minutes
- test_results = shard.ShardAndRunTests(RunnerFactory, attached_devices,
- all_tests, options.build_type,
- setup_timeout=setup_timeout,
- test_timeout=None,
- num_retries=options.num_retries)
+ test_results, exit_code = shard.ShardAndRunTests(
+ RunnerFactory, attached_devices, all_tests, options.build_type,
+ setup_timeout=setup_timeout, test_timeout=None,
+ num_retries=options.num_retries)
report_results.LogFull(
results=test_results,
test_type='Unit test',
test_package=constants.BROWSERTEST_SUITE_NAME,
build_type=options.build_type,
flakiness_server=options.flakiness_dashboard_server)
- report_results.PrintAnnotation(test_results)
- return len(test_results.GetNotPass())
+ return (test_results, exit_code)
def _FilterTests(all_enabled_tests):
« no previous file with comments | « build/android/pylib/base/shard_unittest.py ('k') | build/android/pylib/buildbot_report.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698