Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1721)

Unified Diff: Source/core/platform/DateComponents.h

Issue 18318002: DateComponents shouldn't use bloatedCharacters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix build Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/WeekInputType.cpp ('k') | Source/core/platform/DateComponents.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/DateComponents.h
diff --git a/Source/core/platform/DateComponents.h b/Source/core/platform/DateComponents.h
index b7f6950d9f491da2fc4ce44919ff2bb638ff8d54..2a2c5b740a97acb0e0925b6861d6b2f5f6be0a08 100644
--- a/Source/core/platform/DateComponents.h
+++ b/Source/core/platform/DateComponents.h
@@ -102,17 +102,17 @@ public:
// failures, and the trailing extra characters don't cause parse failures.
// Sets year and month.
- bool parseMonth(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseMonth(const String&, unsigned start, unsigned& end);
// Sets year, month and monthDay.
- bool parseDate(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseDate(const String&, unsigned start, unsigned& end);
// Sets year and week.
- bool parseWeek(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseWeek(const String&, unsigned start, unsigned& end);
// Sets hour, minute, second and millisecond.
- bool parseTime(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseTime(const String&, unsigned start, unsigned& end);
// Sets year, month, monthDay, hour, minute, second and millisecond.
- bool parseDateTimeLocal(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseDateTimeLocal(const String&, unsigned start, unsigned& end);
// Sets year, month, monthDay, hour, minute, second and millisecond, and adjusts timezone.
- bool parseDateTime(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseDateTime(const String&, unsigned start, unsigned& end);
// The following setMillisecondsSinceEpochFor*() functions take
// the number of milliseconds since 1970-01-01 00:00:00.000 UTC as
@@ -172,10 +172,10 @@ private:
// Returns the maximum week number in this DateComponents's year.
// The result is either of 52 and 53.
int maxWeekNumberInYear() const;
- bool parseYear(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseYear(const String&, unsigned start, unsigned& end);
bool addDay(int);
bool addMinute(int);
- bool parseTimeZone(const UChar* src, unsigned length, unsigned start, unsigned& end);
+ bool parseTimeZone(const String&, unsigned start, unsigned& end);
// Helper for millisecondsSinceEpoch().
double millisecondsSinceEpochForTime() const;
// Helpers for setMillisecondsSinceEpochFor*().
« no previous file with comments | « Source/core/html/WeekInputType.cpp ('k') | Source/core/platform/DateComponents.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698