Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Issue 18316002: Move URLRequestContextGetter to RequestSender in c/b/google_apis. (Closed)

Created:
7 years, 5 months ago by kinaba
Modified:
7 years, 5 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move URLRequestContextGetter to RequestSender in c/b/google_apis. Background: I need to add some parameter for each Request object's constructor for addressing Bug 256112, and found that the parameter list is too long. I believe that URLRequestContextGetter logically belongs to the "sender" like user agent or auth tokens do. So the change is logically making sense, not only just shortening the code. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -575 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/contacts/gdata_contacts_service.cc View 7 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 23 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.cc View 21 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/google_apis/base_requests.h View 10 chunks +25 lines, -46 lines 0 comments Download
M chrome/browser/google_apis/base_requests.cc View 10 chunks +22 lines, -41 lines 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/base_requests_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.h View 18 chunks +80 lines, -115 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.cc View 18 chunks +34 lines, -55 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 27 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/google_apis/gdata_contacts_requests.h View 4 chunks +9 lines, -19 lines 0 comments Download
M chrome/browser/google_apis/gdata_contacts_requests.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests.h View 16 chunks +83 lines, -117 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests.cc View 16 chunks +30 lines, -51 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests_unittest.cc View 31 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/google_apis/request_sender.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/request_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
7 years, 5 months ago (2013-07-01 05:37:56 UTC) #1
satorux1
LGTM. Looks cleaner.
7 years, 5 months ago (2013-07-01 06:33:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/18316002/1
7 years, 5 months ago (2013-07-01 06:36:43 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-01 08:03:59 UTC) #4
Message was sent while issue was closed.
Change committed as 209398

Powered by Google App Engine
This is Rietveld 408576698