Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(438)

Issue 18308003: Liberal acceptance of webfont mimetypes (Closed)

Created:
4 years, 5 months ago by paulirish
Modified:
4 years, 5 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Liberal acceptance of webfont mimetypes https://www.google.com/search?q=chrome+font+mime+type MIME types for fonts has been a source of pain for developers, as incorrect types cause excess console spam on every page load. In order to deliver a clean console, let's complain less. Chrome itself doesn't require any particular mimetype. BUG=248712 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153362

Patch Set 1 #

Total comments: 2

Messages

Total messages: 10 (0 generated)
Dmitry Zvorygin
LGTM.
4 years, 5 months ago (2013-07-01 10:14:49 UTC) #1
aandrey
https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js File Source/devtools/front_end/NetworkManager.js (right): https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js#newcode78 Source/devtools/front_end/NetworkManager.js:78: "application/octet-stream": {"font": true}, This mime indicates an arbitrary binary ...
4 years, 5 months ago (2013-07-01 10:53:35 UTC) #2
caseq
On 2013/07/01 10:53:35, aandrey wrote: > https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js > File Source/devtools/front_end/NetworkManager.js (right): > > https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js#newcode78 > ...
4 years, 5 months ago (2013-07-01 11:28:54 UTC) #3
Dmitry Zvorygin
https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js File Source/devtools/front_end/NetworkManager.js (right): https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js#newcode78 Source/devtools/front_end/NetworkManager.js:78: "application/octet-stream": {"font": true}, On 2013/07/01 10:53:35, aandrey wrote: > ...
4 years, 5 months ago (2013-07-01 11:34:59 UTC) #4
aandrey
On 2013/07/01 11:34:59, Dmitry Zvorygin wrote: > https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js > File Source/devtools/front_end/NetworkManager.js (right): > > https://codereview.chromium.org/18308003/diff/1/Source/devtools/front_end/NetworkManager.js#newcode78 ...
4 years, 5 months ago (2013-07-01 11:43:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulirish@chromium.org/18308003/1
4 years, 5 months ago (2013-07-01 17:01:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2738
4 years, 5 months ago (2013-07-01 17:16:42 UTC) #7
pfeldman
lgtm
4 years, 5 months ago (2013-07-01 17:19:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulirish@chromium.org/18308003/1
4 years, 5 months ago (2013-07-01 17:19:44 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2013-07-01 18:52:48 UTC) #10
Message was sent while issue was closed.
Change committed as 153362

Powered by Google App Engine
This is Rietveld 0eb02b776