Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 18298009: chromeos: Remove use_spring_wallpaper and use_oem_wallpaper. (Closed)

Created:
7 years, 5 months ago by Daniel Erat
Modified:
7 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove use_spring_wallpaper and use_oem_wallpaper. Custom wallpapers are now specified via command-line flags. BUG=248764 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M ash/resources/ash_wallpaper_resources.grd View 1 chunk +2 lines, -12 lines 0 comments Download
M build/common.gypi View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
7 years, 5 months ago (2013-07-03 21:44:14 UTC) #1
James Cook
LGTM. Thanks for cleaning up all this. Should this patch also delete the image asset ...
7 years, 5 months ago (2013-07-03 22:04:22 UTC) #2
Daniel Erat
They're in src-internal, so I think that that would need to happen in a separate ...
7 years, 5 months ago (2013-07-03 22:05:43 UTC) #3
James Cook
On 2013/07/03 22:05:43, Daniel Erat wrote: > They're in src-internal, so I think that that ...
7 years, 5 months ago (2013-07-03 22:09:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/18298009/1
7 years, 5 months ago (2013-07-04 00:08:23 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-04 06:05:32 UTC) #6
Message was sent while issue was closed.
Change committed as 210134

Powered by Google App Engine
This is Rietveld 408576698