Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 18297002: Optimize (slightly) Document::updateHoverActiveState. (Closed)

Created:
7 years, 5 months ago by Mike West
Modified:
7 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, esprehn, eseidel
Visibility:
Public.

Description

Optimize (slightly) Document::updateHoverActiveState. When walking up the chain of potentially effected elements, we can stop updating hover state as soon as we hit the common ancestor of the newly hovered element and the previously hovered element. This is a tiny optimization; it should result in no web-visible change in behavior. This patch is extracted from the larger mouseenter/mouseleave WebKit patch[1] submitted by allan.jensen@digia.com (carewolf), reviewed by David Hyatt. [1]: http://trac.webkit.org/changeset/149173, BUG=236215 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153664

Patch Set 1 #

Patch Set 2 : NeedsRebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Mike West
Hey Jochen, mind taking a look at this? I'm splitting carewolf's mouseenter/mouseleave WebKit patch (linked ...
7 years, 5 months ago (2013-06-30 18:03:44 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-01 09:13:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/18297002/1
7 years, 5 months ago (2013-07-01 14:11:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=11569
7 years, 5 months ago (2013-07-01 16:03:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/18297002/1
7 years, 5 months ago (2013-07-01 16:51:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=11586
7 years, 5 months ago (2013-07-01 19:06:00 UTC) #6
Mike West
On 2013/07/01 19:06:00, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 5 months ago (2013-07-02 11:55:40 UTC) #7
Mike West
On 2013/07/02 11:55:40, Mike West (on paternity leave) wrote: > On 2013/07/01 19:06:00, I haz ...
7 years, 5 months ago (2013-07-08 08:20:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/18297002/21001
7 years, 5 months ago (2013-07-08 08:34:15 UTC) #9
commit-bot: I haz the power
Change committed as 153664
7 years, 5 months ago (2013-07-08 09:52:29 UTC) #10
ojan
7 years, 5 months ago (2013-07-08 21:10:06 UTC) #11
Message was sent while issue was closed.
On 2013/07/08 08:20:16, Mike West (on paternity leave) wrote:
> On 2013/07/02 11:55:40, Mike West (on paternity leave) wrote:
> > On 2013/07/01 19:06:00, I haz the power (commit-bot) wrote:
> > > Retried try job too often on win_layout_rel for step(s) webkit_tests
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...
> > 
> > drag-select-1.html looks like it's consistently failing on Windows only,
which
> > is awesome. i'll have to take a look at it when i'm back in the office in a
> week
> > or two.
> 
> Looks like it just needs a trivial rebaseline. I'll use Ojan's amazing new
bot!

w00t! https://codereview.chromium.org/18801010/

Powered by Google App Engine
This is Rietveld 408576698