benchmark/lib/benchmarks/repeated_string_json.dart - Issue 1829573002: Fix all strong mode warnings in protoc-plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: benchmark/lib/benchmarks/repeated_string_json.dart

Issue 1829573002: Fix all strong mode warnings in protoc-plugin (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master

Patch Set: regenerate pb.dart files Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: benchmark/lib/benchmarks/repeated_string_json.dart

diff --git a/benchmark/lib/benchmarks/repeated_string_json.dart b/benchmark/lib/benchmarks/repeated_string_json.dart

index 4dd6a2007c1e7d4f10a91d47983e51eb68501e34..fbbc4e33ad7372a50ff468fc9efebd6e2e022b13 100644

--- a/benchmark/lib/benchmarks/repeated_string_json.dart

+++ b/benchmark/lib/benchmarks/repeated_string_json.dart

@@ -80,7 +80,7 @@ class RepeatedStringBenchmark extends Benchmark {

static const $id = BenchmarkID.READ_STRING_REPEATED_JSON;

static final $type = new BenchmarkType($id, $create);

- static $create(Request r) {

+ static RepeatedStringBenchmark $create(Request r) {

assert(r.params.hasStringFieldCount());

assert(r.params.hasMessageCount());

assert(r.params.hasStringSize());