Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2404)

Unified Diff: benchmark/lib/benchmarks/get_strings.dart

Issue 1829573002: Fix all strong mode warnings in protoc-plugin (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: regenerate pb.dart files Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .analysis_options ('k') | benchmark/lib/benchmarks/has_strings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: benchmark/lib/benchmarks/get_strings.dart
diff --git a/benchmark/lib/benchmarks/get_strings.dart b/benchmark/lib/benchmarks/get_strings.dart
index 72603c16dd453fa632593701d00c0f31fed92022..6b737f172d02d6f63d8c742f27dd7613c5fe6c69 100644
--- a/benchmark/lib/benchmarks/get_strings.dart
+++ b/benchmark/lib/benchmarks/get_strings.dart
@@ -94,7 +94,6 @@ class GetStringsBenchmark extends Benchmark {
}
void _getStrings() {
- var expected = fillValue;
bool ok = true;
for (var line in grid.lines) {
ok = ok && line.cell1.isNotEmpty;
@@ -125,7 +124,7 @@ class GetStringsBenchmark extends Benchmark {
static const $id = BenchmarkID.GET_STRINGS;
static final $type = new BenchmarkType($id, $create);
- static $create(Request r) {
+ static GetStringsBenchmark $create(Request r) {
assert(r.params.hasMessageCount());
var value = null;
if (r.params.hasStringValue()) value = r.params.stringValue;
« no previous file with comments | « .analysis_options ('k') | benchmark/lib/benchmarks/has_strings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698