Fix all strong mode warnings in protoc-plugin

benchmark/lib/report.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protoc.benchmark.report;
 
 import 'dart:convert' show JSON;
 
 import 'generated/benchmark.pb.dart' as pb;
 
@@ skipping 48 matching lines @@
   }
 
   out.packages.addAll(_parseLockFile(pubspecLock));
 
   return out;
 }
 
 /// Quick and dirty lock file parser.
 /// - ignores indentation
 /// - assumes one top-level key "packages:"
-/// - assumes all other lines without a value start a new package
-/// - only allows three known keys within a package
+/// - assumes all other lines without a value except 'description'
+///   start a new package
+/// - only allows known keys within a package
 List<pb.PackageVersion> _parseLockFile(String contents) {
   var out = <pb.PackageVersion>[];
 
   bool inPackages = false;
+  bool inDescription = false;
   pb.PackageVersion pv = null;
   var lineNumber = 0;
   for (var line in contents.split("\n")) {
     lineNumber++;
     line = line.trim(); // ignore indentation
     if (line == "" || line.startsWith("#")) continue;
 
     // find key and value
     var colon = line.indexOf(":");
     if (colon == -1) {
       throw "can't parse pubspec.lock at line $lineNumber";
     }
     var key = line.substring(0, colon).trim();
     var value = line.substring(colon + 1).trim();
     if (value.length >= 2 && value.startsWith('"') && value.endsWith('"')) {
       value = value.substring(1, value.length - 1);
     }
 
     if (!inPackages) {
       if (key == "packages" && value == "") {
         inPackages = true;
         continue;
       }
       throw "can't parse pubspec.lock at line $lineNumber";
     }
 
     if (value == "") {
+      if (key == "description") {
+        inDescription = true;
+        continue;
+      }
       if (pv != null) out.add(pv);
       pv = new pb.PackageVersion()..name = key;
       continue;
     }
 
     if (pv == null) {
-      throw "can't parse pubspec.lock at line $lineNumber";
+      throw "can't parse pubspec.lock at line $lineNumber - no value for $key";
     }
 
+    if (inDescription && (key == "name" || key == "url")) continue;
+    inDescription = false;
+
     switch (key) {
       case "description":
         break;
       case "source":
         pv.source = value;
         break;
       case "version":
         pv.version = value;
         break;
       case "path":
         pv.path = value;
         break;
       case "relative":
         break; // ignore
+      case "sdk":
+        break; // ignore
       default:
-        throw "can't parse pubspec.lock at line $lineNumber";
+        throw "can't parse pubspec.lock at line $lineNumber - unknown key $key";
     }
   }
   return out;
 }
 
 /// Encodes a report as nicely-formatted JSON.
 String encodeReport(pb.Report report) {
   var json = report.writeToJsonMap();
   var out = new StringBuffer();
   _stringifyMap(out, json, "");
@@ skipping 31 matching lines @@
   out.write("[\n");
   bool first = true;
   for (var item in json) {
     if (!first) out.write(",\n");
     first = false;
     out.write(childIndent);
     out.write(JSON.encode(item));
   }
   out.write("\n$indent]");
 }