Remove possiblity of NULL effect in GrEffectStage

Remove possiblity of NULL effect in GrEffectStage

Committed: http://code.google.com/p/skia/source/detail?r=10075

[bsalomon, 2013-07-12 21:02:01]

This is some small cleanup now that GrPaint and GrDrawState don't need
GrEffectStages that don't have effects. It saves some NULL checking, deletes
some code.

[jvanverth1, 2013-07-15 13:20:02]

lgtm + comment

https://codereview.chromium.org/18295008/diff/2001/include/gpu/GrEffectStage.h
File include/gpu/GrEffectStage.h (left):

https://codereview.chromium.org/18295008/diff/2001/include/gpu/GrEffectStage....
include/gpu/GrEffectStage.h:27: }
You may want to make the default constructor private so that it's not
inadvertently called.

[bsalomon, 2013-07-15 13:24:53]

https://codereview.chromium.org/18295008/diff/2001/include/gpu/GrEffectStage.h
File include/gpu/GrEffectStage.h (left):

https://codereview.chromium.org/18295008/diff/2001/include/gpu/GrEffectStage....
include/gpu/GrEffectStage.h:27: }
On 2013/07/15 13:20:02, JimVV wrote:
> You may want to make the default constructor private so that it's not
> inadvertently called.

Since we have other constructors, there is no automatically generated
constructor.

[jvanverth1, 2013-07-15 13:25:52]

On 2013/07/15 13:24:53, bsalomon wrote:
> https://codereview.chromium.org/18295008/diff/2001/include/gpu/GrEffectStage.h
> File include/gpu/GrEffectStage.h (left):
> 
>
https://codereview.chromium.org/18295008/diff/2001/include/gpu/GrEffectStage....
> include/gpu/GrEffectStage.h:27: }
> On 2013/07/15 13:20:02, JimVV wrote:
> > You may want to make the default constructor private so that it's not
> > inadvertently called.
> 
> Since we have other constructors, there is no automatically generated
> constructor.

I have learned something new today.

[commit-bot: I haz the power, 2013-07-15 13:25:55]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/18295008/2001

[commit-bot: I haz the power, 2013-07-15 13:54:09]

Change committed as 10075