Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18292005: Fix bug with parsing capitalized git shas (Closed)

Created:
7 years, 5 months ago by Isaac (away)
Modified:
7 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Fix bug with parsing capitalized git shas Fix identification of shas that contain capitalized hexadecimal characters. Addresses comments from http://crrev.com/18262002/ R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M scm.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Isaac (away)
7 years, 5 months ago (2013-07-08 20:10:01 UTC) #1
M-A Ruel
lgtm
7 years, 5 months ago (2013-07-08 21:38:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/18292005/1
7 years, 5 months ago (2013-07-08 22:00:41 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 22:02:32 UTC) #4
Message was sent while issue was closed. 
Change committed as 210429

Powered by Google App Engine
This is Rietveld 408576698