Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 18291005: Implement Promise.any, Promise.every and Promise.some. (Closed)

Created:
7 years, 5 months ago by yhirano
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement Promise.any, Promise.every and Promise.some. We are implementing DOM/promises. We implement Promise.any, Promise.every and Promise.some in this CL. BUG=243345 R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153703

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -0 lines) Patch
A LayoutTests/fast/js/Promise-static-any.html View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-static-any-expected.txt View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-static-every.html View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-static-every-expected.txt View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-static-some.html View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/fast/js/Promise-static-some-expected.txt View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 2 chunks +151 lines, -0 lines 0 comments Download
M Source/core/dom/Promise.idl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yhirano
7 years, 5 months ago (2013-07-05 03:47:16 UTC) #1
abarth-chromium
Ideally these descriptions would link to the spec.
7 years, 5 months ago (2013-07-08 19:03:08 UTC) #2
abarth-chromium
7 years, 5 months ago (2013-07-08 19:05:00 UTC) #3
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-08 19:05:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18291005/10001
7 years, 5 months ago (2013-07-08 19:05:13 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 20:34:49 UTC) #6
Message was sent while issue was closed.
Change committed as 153703

Powered by Google App Engine
This is Rietveld 408576698