Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1828153002: media: Fix typo in USE_PROPRIETARY_CODECS check. (Closed)

Created:
4 years, 9 months ago by xhwang
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix typo in USE_PROPRIETARY_CODECS check. This is a good example why BUILDFLAG would be better. See issue 596252 for the bug to track using BUILDFLAG in media. BUG=596252 TEST=Initdata parsing works now. Committed: https://crrev.com/2476ed2fc01e9d8a9603e8b3bb7e7bd311e26afa Cr-Commit-Position: refs/heads/master@{#383089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/cdm/browser/widevine_drm_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
xhwang
PTAL
4 years, 9 months ago (2016-03-24 06:27:08 UTC) #2
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-24 16:48:41 UTC) #3
DaleCurtis
Whoops! Thanks for catching. I guess this broke M51 dev too.
4 years, 9 months ago (2016-03-24 16:49:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828153002/1
4 years, 9 months ago (2016-03-24 16:49:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 17:39:36 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 17:40:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2476ed2fc01e9d8a9603e8b3bb7e7bd311e26afa
Cr-Commit-Position: refs/heads/master@{#383089}

Powered by Google App Engine
This is Rietveld 408576698