Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18281002: Move WebDropData to content::DropData and split off conversion function. (Closed)

Created:
7 years, 5 months ago by darin (slow to review)
Modified:
7 years, 5 months ago
Reviewers:
jam, Chris Evans
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, jam, dcheng, joi+watch-content_chromium.org, robertshield, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move WebDropData to content::DropData and split off conversion function. The WebKit::WebDragData constructor is now provided by DropDataBuilder, which lives in content/renderer/. R=jam@chromium.org TBR=cevans@chromium.org BUG=237267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209408

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove spurious include. #

Patch Set 4 : Fix Mac build error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -397 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/aura/tab_contents/web_drag_bookmark_handler_aura.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/web_drag_bookmark_handler_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/web_drag_bookmark_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 6 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_drag_win.h View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_drag_win.cc View 8 chunks +7 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 9 chunks +11 lines, -12 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 6 chunks +7 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_gtk.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_gtk.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 1 2 3 5 chunks +10 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac_unittest.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_win.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 7 chunks +7 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/common/drag_messages.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/drag_traits.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/port/browser/render_view_host_delegate_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/render_view_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_view.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/browser/web_drag_dest_delegate.h View 2 chunks +2 lines, -3 lines 0 comments Download
A + content/public/common/drop_data.h View 1 3 chunks +14 lines, -21 lines 0 comments Download
A content/public/common/drop_data.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
A content/renderer/drop_data_builder.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + content/renderer/drop_data_builder.cc View 1 chunk +22 lines, -35 lines 0 comments Download
M content/renderer/render_view_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 7 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/webclipboard_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/test/test_web_contents_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/test_web_contents_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/common/webdropdata.h View 1 1 chunk +0 lines, -80 lines 0 comments Download
D webkit/common/webdropdata.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
darin (slow to review)
This follows the pattern of ContextMenuParams and ContextMenuParamsBuilder.
7 years, 5 months ago (2013-06-29 22:53:41 UTC) #1
jam
lgtm
7 years, 5 months ago (2013-06-30 18:20:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/18281002/9001
7 years, 5 months ago (2013-06-30 20:21:44 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=13178
7 years, 5 months ago (2013-06-30 20:33:59 UTC) #4
darin (slow to review)
+TBR:cevans@ for IPC review: just renamed a struct, no members changed.
7 years, 5 months ago (2013-07-01 07:08:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/18281002/9001
7 years, 5 months ago (2013-07-01 07:09:00 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-01 11:11:25 UTC) #7
Message was sent while issue was closed. 
Change committed as 209408

Powered by Google App Engine
This is Rietveld 408576698