Issue 18272004: Create top-level ios/public/ directory.

Issue 18272004: Create top-level ios/public/ directory. (Closed)

Created:
7 years, 5 months ago by blundell

Modified:
7 years, 5 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Create top-level ios/public/ directory. To better mirror the structure of other API layers (content/public and third_party/WebKit/public), there will be a single ios/public/ directory that contains all interfaces referenced by not-yet-upstreamed Chrome for iOS code, rather than these interfaces being scattered in subdirectories further underneath ios/. This CL also changes gyp structure to better match other modules: ios_consumer.gyp is moved to directly under ios/, and an ios.gyp is created with a single top-level "ios" target to be used in build/all.gyp. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209434

Patch Set 1 #

Patch Set 2 : Change gypfiles #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -148 lines)			Patch
M	build/all.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ios/consumer/base/supports_user_data.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ios/consumer/base/supports_user_data_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ios/consumer/base/util.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ios/consumer/ios_consumer.gyp	View	1	1 chunk	+0 lines, -41 lines	0 comments	Download
D	ios/consumer/public/DEPS	View		1 chunk	+0 lines, -11 lines	0 comments	Download
D	ios/consumer/public/base/supports_user_data.h	View		1 chunk	+0 lines, -50 lines	0 comments	Download
D	ios/consumer/public/base/util.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
A +	ios/ios.gyp	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download
A +	ios/ios_consumer.gyp	View	1	1 chunk	+12 lines, -12 lines	0 comments	Download
A +	ios/public/DEPS	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ios/public/consumer/base/supports_user_data.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ios/public/consumer/base/util.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/18272004/2001

7 years, 5 months ago (2013-07-01 11:23:27 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 5 months ago (2013-07-01 11:28:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/18272004/2001

7 years, 5 months ago (2013-07-01 11:43:39 UTC) #5

Message was sent while issue was closed.

Change committed as 209434

Expand Messages | Collapse Messages