Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 18260005: Web MIDI: remove old platform API (Closed)

Created:
7 years, 5 months ago by Takashi Toyoshima
Modified:
7 years, 4 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium, dglazkov+blink, jeez, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@midi_permission_request
Visibility:
Public.

Description

Web MIDI: remove old platform API Remove obsoleted APIs, requestAccess of WebMIDIAccessor, and didAllowAccess and didBlockAccess of WebMIDIAccessorClient. TEST=none BUG=163795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155004

Patch Set 1 #

Patch Set 2 : (rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -33 lines) Patch
M Source/core/platform/midi/MIDIAccessor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/midi/MIDIAccessor.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/MockWebMIDIAccessor.h View 1 chunk +1 line, -1 line 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/MockWebMIDIAccessor.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
M public/platform/WebMIDIAccessor.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/platform/WebMIDIAccessorClient.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Takashi Toyoshima
Now that we implement new platform and client APIs in chrome side, I want to ...
7 years, 4 months ago (2013-07-26 05:53:34 UTC) #1
abarth-chromium
lgtm
7 years, 4 months ago (2013-07-26 17:00:58 UTC) #2
abarth-chromium
Thanks!
7 years, 4 months ago (2013-07-26 17:01:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/18260005/2001
7 years, 4 months ago (2013-07-26 17:04:09 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-07-26 19:31:56 UTC) #5
Message was sent while issue was closed.
Change committed as 155004

Powered by Google App Engine
This is Rietveld 408576698