Source/bindings/v8/CustomElementHelpers.cpp - Issue 18258003: Pow __proto__, sock :unresolved, and clunk the created callback at once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementHelpers.cpp

Issue 18258003: Pow __proto__, sock :unresolved, and clunk the created callback at once. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Try to be nicer to MSVC. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/CustomElementHelpers.cpp

diff --git a/Source/bindings/v8/CustomElementHelpers.cpp b/Source/bindings/v8/CustomElementHelpers.cpp

index adbb46be00d56df905853f069e8a43baf197753f..e4d68aa107a7cfbe638ddcc44f17471de43d1e3c 100644

--- a/Source/bindings/v8/CustomElementHelpers.cpp

+++ b/Source/bindings/v8/CustomElementHelpers.cpp

@@ -64,7 +64,7 @@ v8::Handle<v8::Object> CustomElementHelpers::createWrapper(PassRefPtr<Element> i

CustomElementRegistry* registry = impl->document()->registry();

RefPtr<CustomElementDefinition> definition = registry->findFor(impl.get());

- if (!definition)

+ if (!impl->isUpgradedCustomElement() || !definition)

return createUpgradeCandidateWrapper(impl, creationContext, isolate, createTypeExtensionUpgradeCandidateWrapper);

V8PerContextData* perContextData = V8PerContextData::from(context);