Source/bindings/v8/CustomElementConstructorBuilder.h - Issue 18258003: Pow __proto__, sock :unresolved, and clunk the created callback at once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementConstructorBuilder.h

Issue 18258003: Pow __proto__, sock :unresolved, and clunk the created callback at once. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Try to be nicer to MSVC. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/CustomElementConstructorBuilder.h

diff --git a/Source/bindings/v8/CustomElementConstructorBuilder.h b/Source/bindings/v8/CustomElementConstructorBuilder.h

index 828604ef8e441010a7dffa52bc744b42aa95b11e..a0e59bd19277d27ff38fc215b74e8e8b284ca6a9 100644

--- a/Source/bindings/v8/CustomElementConstructorBuilder.h

+++ b/Source/bindings/v8/CustomElementConstructorBuilder.h

@@ -34,7 +34,6 @@

#include "bindings/v8/ScriptValue.h"

#include "core/dom/CustomElementLifecycleCallbacks.h"

#include "core/dom/QualifiedName.h"

-#include "wtf/HashSet.h"

#include "wtf/Noncopyable.h"

#include "wtf/PassRefPtr.h"

#include "wtf/text/AtomicString.h"

@@ -69,7 +68,7 @@ public:

bool findTagName(const AtomicString& customElementType, QualifiedName& tagName) const;

PassRefPtr<CustomElementLifecycleCallbacks> createCallbacks(Document*);

bool createConstructor(Document*, CustomElementDefinition*);

- bool didRegisterDefinition(CustomElementDefinition*, const HashSet<Element*>& upgradeCandidates) const;

+ bool didRegisterDefinition(CustomElementDefinition*) const;

// This method collects a return value for the bindings. It is

// safe to call this method even if the builder failed; it will