Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/bindings/v8/CustomElementConstructorBuilder.cpp

Issue 18258003: Pow __proto__, sock :unresolved, and clunk the created callback at once. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Try to be nicer to MSVC. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/CustomElementConstructorBuilder.h ('k') | Source/bindings/v8/CustomElementHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/CustomElementConstructorBuilder.cpp
diff --git a/Source/bindings/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/v8/CustomElementConstructorBuilder.cpp
index 1f34b14af0b036f34b5935632ac53929aabc49e4..9bbc116dce34fe27e36f7c6b9b393cdeee518f9a 100644
--- a/Source/bindings/v8/CustomElementConstructorBuilder.cpp
+++ b/Source/bindings/v8/CustomElementConstructorBuilder.cpp
@@ -222,7 +222,7 @@ bool CustomElementConstructorBuilder::prototypeIsValid() const
return true;
}
-bool CustomElementConstructorBuilder::didRegisterDefinition(CustomElementDefinition* definition, const HashSet<Element*>& upgradeCandidates) const
+bool CustomElementConstructorBuilder::didRegisterDefinition(CustomElementDefinition* definition) const
{
ASSERT(!m_constructor.IsEmpty());
@@ -234,17 +234,6 @@ bool CustomElementConstructorBuilder::didRegisterDefinition(CustomElementDefinit
v8::Persistent<v8::Object> persistentPrototype(m_context->GetIsolate(), m_prototype);
perContextData->customElementPrototypes()->add(definition->type(), UnsafePersistent<v8::Object>(persistentPrototype));
- // Upgrade any wrappers alcreated created for this definition
- for (HashSet<Element*>::const_iterator it = upgradeCandidates.begin(); it != upgradeCandidates.end(); ++it) {
- v8::Handle<v8::Object> wrapper = DOMDataStore::getWrapperForMainWorld(*it);
- if (wrapper.IsEmpty()) {
- // The wrapper will be created with the right prototype when
- // retrieved; we don't need to eagerly create the wrapper.
- continue;
- }
- wrapper->SetPrototype(m_prototype);
- }
-
return true;
}
« no previous file with comments | « Source/bindings/v8/CustomElementConstructorBuilder.h ('k') | Source/bindings/v8/CustomElementHelpers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698