Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 18252003: Replace third_party/icu/public with third_party/icu/source (Closed)

Created:
7 years, 5 months ago by jungshik at Google
Modified:
7 years, 5 months ago
CC:
chromium-reviews, brettw, Torne, plz use jochen instead, abarth-chromium, cira, tony, sadrul, Xianzhu, yusukes+watch_chromium.org, tzik+watch_chromium.org, Paweł Hajdan Jr., rpetterson, ahutter, browser-components-watch_chromium.org, Albert Bodenhamer, kinuko+watch, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, benquan, stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, derat+watch_chromium.org, rouslan+spellwatch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, Raman Kakilate, rouslan+autofillwatch_chromium.org, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, jshin+watch_chromium.org
Visibility:
Public.

Description

Replace third_party/icu/public with third_party/icu/source in the include directives. This is to move back icu headers in third_party/icu/public/{i18n,common}/unicode back to their upstream locations in third_party/icu/source/{i18n,common}/unicode. http://codereview.chromium.org/18836004 has is a CL to move ICU header files. Roll ICU to the version with the above ICU CL (http://crrev.com/211851 ). In addition to the global replacement of third_party/icu/public with third_party/icu/source, the top-level DEPS, DEPS in printing and chrome/ are tightened up. (the latter two were too permissive (it used to allow any header from third_party/icu). Besides, sync '-foo' list in ios/public/DEPS with '+foo' in the top-level DEPS and build/linux/unbundled/icu.gyp is updated. BUG=251433 TEST=Compile succeeds on all bots. checkdeps.py does not find any error. TBR=brettw,sky,wtc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212324

Patch Set 1 #

Patch Set 2 : update the CL # for the ICU-side change #

Patch Set 3 : more files and tighten up DEPS in chrome,printing #

Patch Set 4 : sync ios/public/DEPS with the top-level DEPS #

Patch Set 5 : update unbundle/icu.gyp for system_icu=1 #

Patch Set 6 : roll ICU to 211851 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -152 lines) Patch
M DEPS View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/date/date_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/date/tray_date.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/i18n/bidi_line_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/break_iterator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/i18n/case_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/char_iterator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/file_util_icu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/icu_encoding_detection.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/i18n/icu_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/number_formatting.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/rtl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/i18n/rtl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_compare.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_search.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_search_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/i18n/time_formatting_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/unbundle/icu.gyp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/character_encoding.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cert_library.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/system_settings_provider.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/snippet.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/term_break_iterator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_char_iterator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/spellcheck_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/time_format.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_country.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_regexes.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/email_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/date_time_formatter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/date_time_formatter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/date_time_formatter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/hyphenator/hyphenator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/public/DEPS View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M net/ftp/ftp_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_content_disposition.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/browser_font_resource_trusted.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/pdf_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/private/ppb_char_set_shared.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M printing/DEPS View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M printing/backend/print_backend.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_collator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/table_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/text_elider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/gurl_test_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_icu.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M url/url_canon_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/webpreferences_renderer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jungshik at Google
Mark, can you take a look? Thanks. I would ask Paweł (he changed the include ...
7 years, 5 months ago (2013-07-14 15:04:51 UTC) #1
Mark Mentovai
LGTM. I spot-checked this.
7 years, 5 months ago (2013-07-15 15:31:54 UTC) #2
jungshik at Google
On 2013/07/15 15:31:54, Mark Mentovai wrote: > LGTM. I spot-checked this. Thank you, Mark. The ...
7 years, 5 months ago (2013-07-16 22:42:08 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm I spot checked as well.
7 years, 5 months ago (2013-07-17 00:38:55 UTC) #4
jungshik at Google
Bot failures are not due to this CL. I'm putting it to CQ.
7 years, 5 months ago (2013-07-17 16:54:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/18252003/14001
7 years, 5 months ago (2013-07-17 17:04:55 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=15723
7 years, 5 months ago (2013-07-17 19:06:52 UTC) #7
jungshik at Google
pre-submit check complained about the owner approval for a bunch of directories. Perhaps, I could ...
7 years, 5 months ago (2013-07-17 20:51:16 UTC) #8
jungshik at Google
On 2013/07/17 20:51:16, Jungshik Shin wrote: > pre-submit check complained about the owner approval for ...
7 years, 5 months ago (2013-07-17 20:52:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/18252003/14001
7 years, 5 months ago (2013-07-18 07:20:08 UTC) #10
commit-bot: I haz the power
Change committed as 212324
7 years, 5 months ago (2013-07-18 11:14:10 UTC) #11
wtc
7 years, 5 months ago (2013-07-25 22:35:36 UTC) #12
Message was sent while issue was closed.
Patch set 6 LGTM. I only reviewed the changes to src/net.

Powered by Google App Engine
This is Rietveld 408576698