ARM Skia NEON patches - 10 - ARM build

ARM Skia NEON patches - 10 - ARM build





ARM-Build: make Linux arm/NEON builds possible

This factorizes the definitions common to Linux & assimilated
and Android. It also enables to do native builds on Linux for
ARM processors.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=9997

[djsollen, 2013-07-10 13:24:17]

https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (left):

https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi#ol...
gyp/common_conditions.gypi:376: [ 'skia_shared_lib', {
why was the condition for skia_shared_lib deleted?

[kevin.petit.not.used.account, 2013-07-10 13:27:47]

https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (left):

https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi#ol...
gyp/common_conditions.gypi:376: [ 'skia_shared_lib', {
On 2013/07/10 13:24:17, djsollen wrote:
> why was the condition for skia_shared_lib deleted?

This is a mistake. It probably happened when I last rebased this.

[borenet, 2013-07-10 13:37:37]

https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi#ne...
gyp/common_conditions.gypi:131: [ 'skia_os in ["linux", "freebsd", "openbsd",
"solaris", "nacl", "chromeos"] or skia_os == "android"',
Just adding "android" to the list would be cleaner.

[kevin.petit.not.used.account, 2013-07-11 09:49:05]

On 2013/07/10 13:37:37, borenet wrote:
> https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi
> File gyp/common_conditions.gypi (right):
> 
>
https://codereview.chromium.org/18243007/diff/1/gyp/common_conditions.gypi#ne...
> gyp/common_conditions.gypi:131: [ 'skia_os in ["linux", "freebsd", "openbsd",
> "solaris", "nacl", "chromeos"] or skia_os == "android"',
> Just adding "android" to the list would be cleaner.

How can I send a fix for the comments that have been made? Do I need to create
another issue? Thanks.

[djsollen, 2013-07-11 12:01:02]

If you are using git-svn you can just do another 'git cl upload' on that branch
and it will create a new patch set.  Also for reference if you run 'git cl
issue' on your branch you should see that it is associated with this review (and
if not you can manually assign a branch to a review).

[kevin.petit.not.used.account, 2013-07-11 12:34:19]

On 2013/07/11 12:01:02, djsollen wrote:
> If you are using git-svn you can just do another 'git cl upload' on that
branch
> and it will create a new patch set.  Also for reference if you run 'git cl
> issue' on your branch you should see that it is associated with this review
(and
> if not you can manually assign a branch to a review).

Thanks for the tip. I uploaded another version that addresses all the comments
received so far.

[djsollen, 2013-07-11 12:38:19]

lgtm

[commit-bot: I haz the power, 2013-07-11 12:40:40]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/18243007/8001

[commit-bot: I haz the power, 2013-07-11 12:48:15]

Change committed as 9997