Issue 18242004: Use the partition allocator and run the test in debug too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18242004: Use the partition allocator and run the test in debug too. (Closed)

Created:
7 years, 5 months ago by Chris Evans

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use the partition allocator and run the test in debug too. We also relax an overly aggressive leak-detecting ASSERT, which is not compatible with a huge number of our tests (both Blink and Chromium) which utilize statically-scoped objects. We keep and use the leak-detection capability for the unit test, though, as it provides a little coverage. BUG=251480 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153462

Patch Set 1 #

Patch Set 2 : Run test in debug. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -14 lines)			Patch
M	Source/core/platform/Partitions.cpp	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/wtf/PartitionAlloc.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/wtf/PartitionAlloc.cpp	View	1	3 chunks	+13 lines, -7 lines	0 comments	Download
M	Source/wtf/PartitionAllocTest.cpp	View	1	4 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/18242004/6001

7 years, 5 months ago (2013-07-02 22:21:52 UTC) #3

Message was sent while issue was closed.

Change committed as 153462

Expand Messages | Collapse Messages