IndexedDB: Remove IndexedDBCallbacksWrapper

IndexedDB: Remove IndexedDBCallbacksWrapper

Eliminate another bit of cruft from the Blink migration by merging
IndexedDBCallbacks and IndexedDBCallbacksWrapper.

BUG=234278
R=alecflett@chromium.org,dgrogan@chromium.org 
TBR=jam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209528

[jsbell, 2013-06-28 23:40:29]

jam@ - OWNERS review of the content_browser.gypi change?
alecflett@, dgrogan@ - please take a look?

This is based on https://chromiumcodereview.appspot.com/18224002/ so that other
CL will need to land first.

The approach I took was as follows:

1. Collapse IndexedDBCallbacks types - instead of Base and impls for callbacks
dealing with databases and cursors, just make one big class. (We can split it
apart again when the we're done with all of this cleanup, if desired.)

2. Isolate IndexedDBCallbacks to be only referenced by IndexedDBCallbacksWrapper

3. Merge the classes

4. Rename all the references from IndexedDBCallbacksWrapper to
IndexedDBCallbacks, delete the old files

5. clang-format

(I have the intermediate states locally and I can post it as incremental CLs if
that helps.)

[alecflett, 2013-06-29 00:07:30]

lgtm

lgtm

https://chromiumcodereview.appspot.com/18241003/diff/1/content/browser/indexe...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://chromiumcodereview.appspot.com/18241003/diff/1/content/browser/indexe...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:261:
DeleteDatabase(params.name,
argh, clang-format - I liked the old wrapping better :)

https://chromiumcodereview.appspot.com/18241003/diff/1/content/browser/indexe...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:389:
IPC_MESSAGE_HANDLER(IndexedDBHostMsg_DatabaseCreateObjectStore,
did you mean to chnage the indentation?

[jsbell, 2013-07-01 16:37:28]

https://chromiumcodereview.appspot.com/18241003/diff/1/content/browser/indexe...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://chromiumcodereview.appspot.com/18241003/diff/1/content/browser/indexe...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:261:
DeleteDatabase(params.name,
On 2013/06/29 00:07:30, alecflett wrote:
> argh, clang-format - I liked the old wrapping better :)

Me too. clang-format gets the -> "wrong" anyway so this required manual
adjustment. Fixed.

https://chromiumcodereview.appspot.com/18241003/diff/1/content/browser/indexe...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:389:
IPC_MESSAGE_HANDLER(IndexedDBHostMsg_DatabaseCreateObjectStore,
On 2013/06/29 00:07:30, alecflett wrote:
> did you mean to chnage the indentation?

Fixed. (Can blame emacs for that one. clang-format can't handle the macros)

[jam, 2013-07-01 18:19:54]

lgtm

[commit-bot: I haz the power, 2013-07-01 20:43:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/18241003/4002

[commit-bot: I haz the power, 2013-07-01 22:54:11]

Change committed as 209528