media/mojo/interfaces/audio_decoder.mojom - Issue 1823443002: Use data pipe for encoded buffers in MojoAudioDecoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/interfaces/audio_decoder.mojom

Issue 1823443002: Use data pipe for encoded buffers in MojoAudioDecoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@spitzer-audio-service-impl

Patch Set: Addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/mojo/interfaces/audio_decoder.mojom

diff --git a/media/mojo/interfaces/audio_decoder.mojom b/media/mojo/interfaces/audio_decoder.mojom

index bb4f0591e2850c003bbcc8b5244c6dd4d08c2791..70a27550d1ba6e10f91f051f12f78e952723be04 100644

--- a/media/mojo/interfaces/audio_decoder.mojom

+++ b/media/mojo/interfaces/audio_decoder.mojom

@@ -21,6 +21,9 @@ interface AudioDecoder {

Initialize(AudioDecoderClient client, AudioDecoderConfig config, int32 cdm_id)

=> (bool success, bool needs_bitstream_conversion);

+ // Established data connection. Should be called before Decode().

sandersd (OOO until July 31) 2016/03/21 23:12:38 nit: Should say 'Establish', or perhaps a differen

+ SetDataSource(handle<data_pipe_consumer> receive_pipe);

// Sends the |buffer| to the underlying codec. Should be called only after

// Initialize() succeeds. The callback with the status is called after the

// decoder has accepted corresponding DecoderBuffer, indicating that the

« no previous file with comments | « no previous file | media/mojo/services/mojo_audio_decoder.h » ('j') | no next file with comments »