Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: media/mojo/interfaces/audio_decoder.mojom

Issue 1823443002: Use data pipe for encoded buffers in MojoAudioDecoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@spitzer-audio-service-impl
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/mojo/services/mojo_audio_decoder.h » ('j') | media/mojo/services/mojo_audio_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/interfaces/audio_decoder.mojom
diff --git a/media/mojo/interfaces/audio_decoder.mojom b/media/mojo/interfaces/audio_decoder.mojom
index bb4f0591e2850c003bbcc8b5244c6dd4d08c2791..70a27550d1ba6e10f91f051f12f78e952723be04 100644
--- a/media/mojo/interfaces/audio_decoder.mojom
+++ b/media/mojo/interfaces/audio_decoder.mojom
@@ -21,6 +21,9 @@ interface AudioDecoder {
Initialize(AudioDecoderClient client, AudioDecoderConfig config, int32 cdm_id)
=> (bool success, bool needs_bitstream_conversion);
+ // Established data connection. Should be called before Decode().
+ SetDataSource(handle<data_pipe_consumer> receive_pipe);
xhwang 2016/03/19 04:57:25 See comment below. I wonder whether it'll be bette
Tima Vaisburd 2016/03/19 22:04:46 I considered that, but thought that we'd like to h
xhwang 2016/03/20 16:15:57 You are right. I remembered that DataPipe creation
+
// Sends the |buffer| to the underlying codec. Should be called only after
// Initialize() succeeds. The callback with the status is called after the
// decoder has accepted corresponding DecoderBuffer, indicating that the
« no previous file with comments | « no previous file | media/mojo/services/mojo_audio_decoder.h » ('j') | media/mojo/services/mojo_audio_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698