content/common/gpu/media/vt_video_decode_accelerator_mac.cc - Issue 1822983002: Support external buffer import in VDA interface and add a V4L2SVDA impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/vt_video_decode_accelerator_mac.cc

Issue 1822983002: Support external buffer import in VDA interface and add a V4L2SVDA impl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: include reland of crrev.com/1643123003 with fixes and rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc ('K') | « content/common/gpu/media/video_decode_accelerator_unittest.cc ('k') | content/public/gpu/gpu_video_decode_accelerator_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/vt_video_decode_accelerator_mac.cc

diff --git a/content/common/gpu/media/vt_video_decode_accelerator_mac.cc b/content/common/gpu/media/vt_video_decode_accelerator_mac.cc

index f6824c5ba8ec9b8ef54c66e38c5aacc54ed5b225..e37fe4e4b651c24f7df5fca14d54ae2f283b13a8 100644

--- a/content/common/gpu/media/vt_video_decode_accelerator_mac.cc

+++ b/content/common/gpu/media/vt_video_decode_accelerator_mac.cc

@@ -329,6 +329,11 @@ bool VTVideoDecodeAccelerator::Initialize(const Config& config,

return false;

}

+ if (config.output_mode != Config::OutputMode::ALLOCATE) {

+ NOTREACHED() << "Only ALLOCATE OutputMode is supported by this VDA";

+ return false;

+ }

client_ = client;

if (!InitializeVideoToolbox())