Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 1822983002: Support external buffer import in VDA interface and add a V4L2SVDA impl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/gpu_video_decoder.cc
diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc
index 0109dc7dae39901d94d3fb7a493da6aa722941bd..6a84dede9800e8b69bff3787d3f70058908599e6 100644
--- a/media/filters/gpu_video_decoder.cc
+++ b/media/filters/gpu_video_decoder.cc
@@ -510,10 +510,8 @@ void GpuVideoDecoder::PictureReady(const media::Picture& picture) {
DCHECK(decoder_texture_target_);
- bool opaque = IsOpaque(config_.format());
-
scoped_refptr<VideoFrame> frame(VideoFrame::WrapNativeTexture(
- opaque ? PIXEL_FORMAT_XRGB : PIXEL_FORMAT_ARGB,
+ vda_->GetOutputFormat(),
kcwu 2016/03/22 07:47:02 The original code will use XRGB for some cases. Bu
Pawel Osciak 2016/03/28 01:31:29 If a VDA doesn't implement GetOutputFormat(), it w
Pawel Osciak 2016/03/28 01:59:10 Sorry, I meant ARGB. As for the choice between XRG
gpu::MailboxHolder(pb.texture_mailbox(), gpu::SyncToken(),
decoder_texture_target_),
BindToCurrentLoop(base::Bind(

Powered by Google App Engine
This is Rietveld 408576698