Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 18228003: Remove AtomicStringImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/css/CSSSelector.h » ('j') | Source/wtf/text/AtomicString.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 Frame* frame = 0; 442 Frame* frame = 0;
443 if (node->hasTagName(HTMLNames::iframeTag) && (frame = static_cast<HTMLI FrameElement*>(node)->contentFrame())) 443 if (node->hasTagName(HTMLNames::iframeTag) && (frame = static_cast<HTMLI FrameElement*>(node)->contentFrame()))
444 return toV8(frame->document()->domWindow(), creationContext, isolate ); 444 return toV8(frame->document()->domWindow(), creationContext, isolate );
445 return toV8(node, creationContext, isolate); 445 return toV8(node, creationContext, isolate);
446 } 446 }
447 return toV8(items.release(), creationContext, isolate); 447 return toV8(items.release(), creationContext, isolate);
448 } 448 }
449 449
450 static void getter(v8::Local<v8::String> property, const v8::PropertyCallbackInf o<v8::Value>& info) 450 static void getter(v8::Local<v8::String> property, const v8::PropertyCallbackInf o<v8::Value>& info)
451 { 451 {
452 // FIXME: Consider passing AtomicStringImpl directly. 452 // FIXME: Consider passing StringImpl directly.
453 AtomicString name = toWebCoreAtomicString(property); 453 AtomicString name = toWebCoreAtomicString(property);
454 HTMLDocument* htmlDocument = V8HTMLDocument::toNative(info.Holder()); 454 HTMLDocument* htmlDocument = V8HTMLDocument::toNative(info.Holder());
455 ASSERT(htmlDocument); 455 ASSERT(htmlDocument);
456 v8::Handle<v8::Value> result = getNamedProperty(htmlDocument, name, info.Hol der(), info.GetIsolate()); 456 v8::Handle<v8::Value> result = getNamedProperty(htmlDocument, name, info.Hol der(), info.GetIsolate());
457 if (!result.IsEmpty()) { 457 if (!result.IsEmpty()) {
458 v8SetReturnValue(info, result); 458 v8SetReturnValue(info, result);
459 return; 459 return;
460 } 460 }
461 v8::Handle<v8::Value> prototype = info.Holder()->GetPrototype(); 461 v8::Handle<v8::Value> prototype = info.Holder()->GetPrototype();
462 if (prototype->IsObject()) { 462 if (prototype->IsObject()) {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 void V8WindowShell::updateSecurityOrigin() 503 void V8WindowShell::updateSecurityOrigin()
504 { 504 {
505 ASSERT(m_world->isMainWorld()); 505 ASSERT(m_world->isMainWorld());
506 if (m_context.isEmpty()) 506 if (m_context.isEmpty())
507 return; 507 return;
508 v8::HandleScope handleScope; 508 v8::HandleScope handleScope;
509 setSecurityToken(); 509 setSecurityToken();
510 } 510 }
511 511
512 } // WebCore 512 } // WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSSelector.h » ('j') | Source/wtf/text/AtomicString.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698