Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 18224002: IndexedDB: Eliminate IndexedDBDatabaseCallbacksWrapper (Closed)

Created:
7 years, 5 months ago by jsbell
Modified:
7 years, 5 months ago
Reviewers:
alecflett, jam, dgrogan
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

IndexedDB: Eliminate IndexedDBDatabaseCallbacksWrapper The wrapper class was introduced to provide a refcounted wrapper around a non-refcounted object during the migration from Blink. Collapse the two types into one. BUG=234278 R=alecflett@chromium.org, jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209486

Patch Set 1 #

Patch Set 2 : Include tidying #

Patch Set 3 : Rebased #

Patch Set 4 : Include fix for win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -161 lines) Patch
M content/browser/indexed_db/indexed_db_callbacks_wrapper.h View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks_wrapper.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.h View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.h View 1 1 chunk +26 lines, -10 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.cc View 3 chunks +20 lines, -7 lines 0 comments Download
D content/browser/indexed_db/indexed_db_database_callbacks_wrapper.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/indexed_db/indexed_db_database_callbacks_wrapper.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/webidbdatabase_impl.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/indexed_db/webidbdatabase_impl.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jsbell
More wrapper type elimination. This will make the elimination of WebIDBDatabaseImpl easier. Locally, I have ...
7 years, 5 months ago (2013-06-28 18:36:10 UTC) #1
jsbell
+dgrogan as reviewer
7 years, 5 months ago (2013-06-28 18:45:59 UTC) #2
jam
gypi lgtm
7 years, 5 months ago (2013-06-28 22:16:50 UTC) #3
alecflett
lgtm
7 years, 5 months ago (2013-06-29 00:01:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/18224002/8001
7 years, 5 months ago (2013-07-01 16:14:51 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-01 17:35:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/18224002/29001
7 years, 5 months ago (2013-07-01 18:35:21 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=171397
7 years, 5 months ago (2013-07-01 19:51:51 UTC) #8
jsbell
7 years, 5 months ago (2013-07-01 20:21:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r209486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698