Issue 18216003: Fix an assertion failure in rendererIsFocusable of form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18216003: Fix an assertion failure in rendererIsFocusable of form controls. (Closed)

Created:
7 years, 5 months ago by tkent

Modified:
7 years, 5 months ago

Reviewers:
keishi

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix an assertion failure in rendererIsFocusable of form controls. If a form control has :active CSS rule, pressing a label element for the control can make the control needsLayout state. We should make sure that isMouseFocusable uses the latest layout information by calling updateLayoutIgnorePendingStylesheets. BUG=255316 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153369

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -2 lines)			Patch
A	LayoutTests/fast/forms/label/label-assertion-with-active-style.html	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/forms/label/label-assertion-with-active-style-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/html/HTMLLabelElement.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/18216003/1

7 years, 5 months ago (2013-07-01 20:44:58 UTC) #3

Message was sent while issue was closed.

Change committed as 153369

Expand Messages | Collapse Messages